Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2033813005: [tools/perf] Make pages in typical_25 page_set to wait for load event to triggered (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Make pages in typical_25 page_set to wait for load event to triggered BUG=617004 Committed: https://crrev.com/7289aea063487fc7f4ff64d8a7ce2c7f7a0e023b Cr-Commit-Position: refs/heads/master@{#397905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/page_sets/typical_25.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nednguyen
PTAL
4 years, 6 months ago (2016-06-03 13:05:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033813005/1
4 years, 6 months ago (2016-06-03 13:06:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 14:26:37 UTC) #6
kouhei (in TOK)
lgtm
4 years, 6 months ago (2016-06-04 04:54:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033813005/1
4 years, 6 months ago (2016-06-04 04:54:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 04:58:01 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 04:59:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7289aea063487fc7f4ff64d8a7ce2c7f7a0e023b
Cr-Commit-Position: refs/heads/master@{#397905}

Powered by Google App Engine
This is Rietveld 408576698