tools/perf/page_sets/typical_25.py - Issue 2033813005: [tools/perf] Make pages in typical_25 page_set to wait for load event to triggered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/typical_25.py

Issue 2033813005: [tools/perf] Make pages in typical_25 page_set to wait for load event to triggered (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/typical_25.py

diff --git a/tools/perf/page_sets/typical_25.py b/tools/perf/page_sets/typical_25.py

index 8f056c143767073ab231703a7263d6fe42934392..5e9d8c372b4e8b142349f43b4d2d54470550bdd8 100644

--- a/tools/perf/page_sets/typical_25.py

+++ b/tools/perf/page_sets/typical_25.py

@@ -50,6 +50,8 @@ class Typical25Page(page_module.Page):

def RunPageInteractions(self, action_runner):

if self._run_no_page_interactions:

+ action_runner.WaitForJavaScriptCondition(

+ 'performance.timing.loadEventStart > 0')

return

with action_runner.CreateGestureInteraction('ScrollAction'):

action_runner.ScrollPage()

« no previous file with comments | « no previous file | no next file » | no next file with comments »