Remove use of deprecated MessageLoop methods in chrome/.

Remove use of deprecated MessageLoop methods in chrome/.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
Committed: https://crrev.com/283082bd73d2873a5bafefcda09e0f182100e77f
Cr-Commit-Position: refs/heads/master@{#397497}

[fdoray, 2016-06-02 14:27:19]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 14:27:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033753002/1

[commit-bot: I haz the power, 2016-06-02 14:46:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 14:46:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-06-02 14:55:01]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 14:55:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033753002/20001

[commit-bot: I haz the power, 2016-06-02 15:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 15:15:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-06-02 15:19:24]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 15:19:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033753002/40001

[commit-bot: I haz the power, 2016-06-02 16:43:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 16:43:06]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-06-02 16:47:48]

message_loop_cleanup.py:

import os
import re

LOCATION_HEADER = 'base/location.h'
THREAD_TASK_RUNNER_HANDLER_HEADER = 'base/threading/thread_task_runner_handle.h'
SINGLE_THREAD_TASK_RUNNER_HEADER = 'base/single_thread_task_runner.h'

# Get content of the header file associated with |source_path|.
def HeaderContent(source_path):
  header_path = os.path.splitext(source_path)[0] + '.h'
  try:
    with open(header_path, 'r') as f:
      return f.read()
  except IOError:
    return None

# Returns true if |content| includes |include_path|.
def SourceIncludes(content, include_path):
  if content is None:
    return False
  return ('#include "' + include_path + '"') in content

# Returns true if MessageLoop, MessageLoopForUI or MessageLoopForIO is used in
# |content|.
def UsesMessageLoop(content):
  if re.search(r'[^a-zA-z]MessageLoop(ForUI|ForIO)?[^a-zA-Z]', content):
    return True
  if 'message_loop()' in content:
    print '  Uses message_loop()'
    return True
  return False

def FixIncludes(content, path):
  uses_message_loop = UsesMessageLoop(content)

  found_if = False
  num_includes = 0
  include_index = -1;

  lines = content.splitlines()

  for index, line in enumerate(lines):
    if line.startswith('#'):
      if line.startswith('#if'):
        found_if = True
      elif (line.startswith('#include "') or
            line.startswith('#import "')) and not found_if:
        if num_includes <= 1:
          include_index = index
        num_includes = num_includes + 1

  updated_lines = []
  for index, line in enumerate(lines):
    if index == include_index:
      # Append new includes.
      header_content = HeaderContent(path)

      if (not SourceIncludes(content, LOCATION_HEADER) and
          not SourceIncludes(header_content, LOCATION_HEADER)):
        updated_lines.append('#include "' + LOCATION_HEADER + '"')

      if (not SourceIncludes(content, THREAD_TASK_RUNNER_HANDLER_HEADER) and
          not SourceIncludes(header_content,
THREAD_TASK_RUNNER_HANDLER_HEADER)):
        updated_lines.append('#include "' + THREAD_TASK_RUNNER_HANDLER_HEADER +
'"')

      if (not SourceIncludes(content, SINGLE_THREAD_TASK_RUNNER_HEADER) and
          not SourceIncludes(header_content, SINGLE_THREAD_TASK_RUNNER_HEADER)):
        updated_lines.append('#include "' + SINGLE_THREAD_TASK_RUNNER_HEADER +
'"')

    # Remove message_loop.h include if it is no longer required.
    if not uses_message_loop and line == '#include
"base/message_loop/message_loop.h"':
      continue

    # Append current line.
    updated_lines.append(line)

  updated_content = '\n'.join(updated_lines)
  return updated_content

def FixCalls(path):
  with open(path, 'r') as f:
    content = f.read()

  updated_content = re.sub(
    r'MessageLoop(ForUI|ForIO)?::current\(\)\s*->\s*PostTask\(',
    'ThreadTaskRunnerHandle::Get()->PostTask(',
    content)
  updated_content = re.sub(
    r'MessageLoop(ForUI|ForIO)?::current\(\)\s*->\s*PostDelayedTask\(',
    'ThreadTaskRunnerHandle::Get()->PostDelayedTask(',
    updated_content)
  updated_content = re.sub(
    r'MessageLoop(ForUI|ForIO)?::current\(\)\s*->\s*DeleteSoon\(',
    'ThreadTaskRunnerHandle::Get()->DeleteSoon(',
    updated_content)
  updated_content = re.sub(
    r'MessageLoop(ForUI|ForIO)?::current\(\)\s*->\s*ReleaseSoon\(',
    'ThreadTaskRunnerHandle::Get()->ReleaseSoon(',
    updated_content)

  if content != updated_content:
    print 'fixed ' + path
    updated_content = FixIncludes(updated_content, path)
    with open(path, 'wb') as f:
      f.write(updated_content)
      f.write('\n')

def main():
  root = 'C:\\src\\chromium\\src'

  for d in os.walk(root):
    for f in d[2]:
      if os.path.splitext(f)[1] == ".cc":
        path = os.path.join(d[0], f)
        FixCalls(path)

if __name__ == "__main__":
    main()

[fdoray, 2016-06-02 16:48:09]

Description was changed from

==========
Remove use of deprecated MessageLoop methods in chrome/.

This patch makes the following replacements in chrome/:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayed" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, these includes are added:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"
And this include is removed if no longer required:
  #include "base/message_loop/message_loop.h"

In base/task_scheduler, MessageLoop::current() will return nullptr.
This CL is therefore a prerequisite to the migration of the browser
to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see comment #3 on this CL).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
==========

to

==========
Remove use of deprecated MessageLoop methods in chrome/.

This patch makes the following replacements in chrome/:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayed" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, these includes are added:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"
And this include is removed if no longer required:
  #include "base/message_loop/message_loop.h"

In base/task_scheduler, MessageLoop::current() will return nullptr.
This CL is therefore a prerequisite to the migration of the browser
to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see comment #13 on this CL).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
==========

[fdoray, 2016-06-02 16:48:30]

fdoray@chromium.org changed reviewers:
+ thakis@chromium.org

[fdoray, 2016-06-02 16:48:31]

Can you review this CL? Thanks.

[Nico, 2016-06-02 18:09:24]

https://code.google.com/p/chromium/codesearch#chromium/src/base/message_loop/...
doesn't say anything about ::current() being deprecated from what I can tell.
What's the motivation for this? Why can't MessageLoop::current() be changed to
do what you want to do?

(Not saying this CL is wrong, I just don't understand its motivation)

[fdoray, 2016-06-02 19:01:53]

On 2016/06/02 18:09:24, Nico wrote:
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/message_loop/...
> doesn't say anything about ::current() being deprecated from what I can tell.
> What's the motivation for this? Why can't MessageLoop::current() be changed to
> do what you want to do?
> 
> (Not saying this CL is wrong, I just don't understand its motivation)

This CL removes calls to
MessageLoop::PostTask/PostDelayedTask/ReleaseSoon/DeleteSoon which are
deprecated
https://code.google.com/p/chromium/codesearch#chromium/src/base/message_loop/...

I could have replaced MessageLoop::current()->PostTask/... with
MessageLoop::current()->task_runner()->PostTask/... However, many MessageLoop
threads running in the browser will soon be migrated to base/task_scheduler [1]
where MessageLoop::current() returns nullptr. ThreadTaskRunnerHandle::Get() is
equivalent to MessageLoop::current()->task_runner() on threads that run a
MessageLoop and is base/task_scheduler/-friendly.

Why does MessageLoop::current() returns nullptr in base/task_scheduler? Threads
in base/task_scheduler don't run a MessageLoop. We could register a fake
MessageLoop that redirects tasks to base/task_scheduler on these threads.
However, we think this a a bad idea because:
- It's confusing. You get a MessageLoop but you're not really on a MessageLoop.
- Some methods of this fake MessageLoop can't be called (e.g. QuitNow() or
RunUntilIdle() don't make sense in base/task_scheduler).

[1] design doc visible to @chromium.org:
https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa...

[Nico, 2016-06-02 19:25:14]

Can you add some of that either to the cl description or the linked bug? with
that, rs-lgtm

[fdoray, 2016-06-02 20:00:36]

Description was changed from

==========
Remove use of deprecated MessageLoop methods in chrome/.

This patch makes the following replacements in chrome/:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayed" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, these includes are added:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"
And this include is removed if no longer required:
  #include "base/message_loop/message_loop.h"

In base/task_scheduler, MessageLoop::current() will return nullptr.
This CL is therefore a prerequisite to the migration of the browser
to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see comment #13 on this CL).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
==========

to

==========
Remove use of deprecated MessageLoop methods in chrome/.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
==========

[fdoray, 2016-06-02 20:09:09]

On 2016/06/02 19:25:14, Nico wrote:
> Can you add some of that either to the cl description or the linked bug? with
> that, rs-lgtm

Done. Improved CL description and added "Why does MessageLoop::current() returns
nullptr in base/task_scheduler?" to the bug.

[fdoray, 2016-06-02 20:09:21]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-06-02 20:10:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033753002/40001

[dcheng, 2016-06-02 20:15:00]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-06-02 20:15:02]

Shouldn't there be some sort of PSA about these changes?

[fdoray, 2016-06-02 20:16:52]

On 2016/06/02 20:15:02, dcheng wrote:
> Shouldn't there be some sort of PSA about these changes?

About removing calls to deprecated MessageLoop API or about the migration to
base/task_scheduler?

[commit-bot: I haz the power, 2016-06-02 20:19:01]

Description was changed from

==========
Remove use of deprecated MessageLoop methods in chrome/.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
==========

to

==========
Remove use of deprecated MessageLoop methods in chrome/.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
==========

[commit-bot: I haz the power, 2016-06-02 20:19:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-02 20:20:15]

Description was changed from

==========
Remove use of deprecated MessageLoop methods in chrome/.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
==========

to

==========
Remove use of deprecated MessageLoop methods in chrome/.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447

Committed: https://crrev.com/283082bd73d2873a5bafefcda09e0f182100e77f
Cr-Commit-Position: refs/heads/master@{#397497}
==========

[commit-bot: I haz the power, 2016-06-02 20:20:22]

Patchset 3 (id:??) landed as
https://crrev.com/283082bd73d2873a5bafefcda09e0f182100e77f
Cr-Commit-Position: refs/heads/master@{#397497}

[dcheng, 2016-06-02 20:36:05]

On 2016/06/02 at 20:16:52, fdoray wrote:
> On 2016/06/02 20:15:02, dcheng wrote:
> > Shouldn't there be some sort of PSA about these changes?
> 
> About removing calls to deprecated MessageLoop API or about the migration to
base/task_scheduler?

Both, really.