chrome/browser/download/notification/download_notification_manager.cc - Issue 2033753002: Remove use of deprecated MessageLoop methods in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_notification_manager.cc

Issue 2033753002: Remove use of deprecated MessageLoop methods in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: manual change Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/chrome_download_manager_delegate_unittest.cc ('k') | chrome/browser/extensions/api/gcd_private/privet_v3_context_getter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/notification/download_notification_manager.cc

diff --git a/chrome/browser/download/notification/download_notification_manager.cc b/chrome/browser/download/notification/download_notification_manager.cc

index da005bd10678df61d92929b75fa5d7951745cda8..62b739dd257c18b7949e4a19c7df8ade08f17544 100644

--- a/chrome/browser/download/notification/download_notification_manager.cc

+++ b/chrome/browser/download/notification/download_notification_manager.cc

@@ -5,7 +5,10 @@

#include "chrome/browser/download/notification/download_notification_manager.h"

#include "base/command_line.h"

+#include "base/location.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/string_number_conversions.h"

+#include "base/threading/thread_task_runner_handle.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/download/download_item_model.h"

#include "chrome/browser/download/notification/download_item_notification.h"

@@ -41,7 +44,8 @@ void DownloadNotificationManager::OnAllDownloadsRemoving(Profile* profile) {

manager_for_profile_[profile];

manager_for_profile_.erase(profile);

- base::MessageLoop::current()->DeleteSoon(FROM_HERE, manager_for_profile);

+ base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE,

+ manager_for_profile);

}

void DownloadNotificationManager::OnNewDownloadReady(

@@ -107,7 +111,7 @@ void DownloadNotificationManagerForProfile::OnDownloadRemoved(

// This removing might be initiated from DownloadNotificationItem, so delaying

// deleting for item to do remaining cleanups.

- base::MessageLoop::current()->DeleteSoon(FROM_HERE, item);

+ base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, item);

if (items_.size() == 0 && parent_manager_)

parent_manager_->OnAllDownloadsRemoving(profile_);