Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 2033713002: Implement the Chrome Sign-in promo bubble for password manager on Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix model Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index 667f6e9dc5f4781901125ee5c18af85af074701e..a2c5716b2402448c25021ad0dce8d124afbddf1f 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -73,6 +73,12 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
void OnPasswordAction(const autofill::PasswordForm& password_form,
PasswordAction action);
+ // Called by the view when the "Sign in" button in the promo bubble clicked.
vabr (Chromium) 2016/06/02 13:10:55 nit: clicked -> is clicked (Also below.)
vasilii 2016/06/02 13:36:18 Done.
+ void OnSignInToChromeClicked();
+
+ // Called by the view when the "No thanks" button in the promo bubble clicked.
+ void OnSkipSignInClicked();
+
password_manager::ui::State state() const { return state_; }
const base::string16& title() const { return title_; }
@@ -105,6 +111,9 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Lock.
bool ShouldShowGoogleSmartLockWelcome() const;
+ // Returns true iff the Save bubble should switch to the Chrome Sign In promo.
+ bool ShouldShowSignInPromo();
vabr (Chromium) 2016/06/02 13:10:55 The method has side-effects which are not mentione
vasilii 2016/06/02 13:36:18 Done.
+
void SetClockForTesting(std::unique_ptr<base::Clock> clock);
private:

Powered by Google App Engine
This is Rietveld 408576698