Implement the Chrome Sign-in promo bubble for password manager on Views.

chrome/browser/ui/passwords/manage_passwords_bubble_model.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 
 #include <utility>
 
 #include "base/macros.h"
@@ skipping 55 matching lines @@
 
   // Called by the view code when the auto-signin toast is about to close due to
   // timeout.
   void OnAutoSignInToastTimeout();
 
   // Called by the view code to delete or add a password form to the
   // PasswordStore.
   void OnPasswordAction(const autofill::PasswordForm& password_form,
                         PasswordAction action);
 
+  // Called by the view when the "Sign in" button in the promo bubble clicked.

[vabr (Chromium), 2016/06/02 13:10:55]

nit: clicked -> is clicked

(Also below.)

[vasilii, 2016/06/02 13:36:18]

Done.

+  void OnSignInToChromeClicked();
+
+  // Called by the view when the "No thanks" button in the promo bubble clicked.
+  void OnSkipSignInClicked();
+
   password_manager::ui::State state() const { return state_; }
 
   const base::string16& title() const { return title_; }
   const autofill::PasswordForm& pending_password() const {
     return pending_password_;
   }
   // Returns the available credentials which match the current site.
   const ScopedVector<const autofill::PasswordForm>& local_credentials() const {
     return local_credentials_;
   }
@@ skipping 12 matching lines @@
   Profile* GetProfile() const;
 
   // Returns true iff the multiple account selection prompt for account update
   // should be presented.
   bool ShouldShowMultipleAccountUpdateUI() const;
 
   // True if the save bubble should display the warm welcome for Google Smart
   // Lock.
   bool ShouldShowGoogleSmartLockWelcome() const;
 
+  // Returns true iff the Save bubble should switch to the Chrome Sign In promo.
+  bool ShouldShowSignInPromo();

[vabr (Chromium), 2016/06/02 13:10:55]

The method has side-effects which are not mentioned in the comment, and are not
obvious from the method name. What about:

bool UpdateToShowSignInPromoIfAppropriate()

or something similar?

[vasilii, 2016/06/02 13:36:18]

Done.

+
   void SetClockForTesting(std::unique_ptr<base::Clock> clock);
 
  private:
   enum UserBehaviorOnUpdateBubble {
     UPDATE_CLICKED,
     NOPE_CLICKED,
     NO_INTERACTION
   };
   class InteractionKeeper;
   // Updates |title_| and |title_brand_link_range_| for the
@@ skipping 17 matching lines @@
   base::string16 save_confirmation_text_;
   gfx::Range save_confirmation_link_range_;
 
   // Responsible for recording all the interactions required.
   std::unique_ptr<InteractionKeeper> interaction_keeper_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_