Adjust representation of liveDocumentSet() to help diagnose instability.

Adjust representation of liveDocumentSet() to help diagnose instability.

The liveDocumentSet singleton keeps a

 Persistent<HeapHashSet<WeakMember<Document>>,

collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.

To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with an (Oilpan) heap object
overwrite here.

R=
BUG=611702
Committed: https://crrev.com/a606534af4c30e4c92e454d4bd54f09114d08374
Cr-Commit-Position: refs/heads/master@{#397436}

[sof, 2016-06-02 11:01:41]

Description was changed from

==========
Adjust representation of liveDocumentSet() to help diagnose instability.

The liveDocumentSet singleton keeps a

 Persistent<HeapHashSet<WeakMember<Document>>,

collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.

To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with a (Oilpan) heap object
overwrite here.

R=
BUG=611702
==========

to

==========
Adjust representation of liveDocumentSet() to help diagnose instability.

The liveDocumentSet singleton keeps a

 Persistent<HeapHashSet<WeakMember<Document>>,

collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.

To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with an (Oilpan) heap object
overwrite here.

R=
BUG=611702
==========

[sof, 2016-06-02 11:02:33]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-06-02 11:02:34]

please take a look.

[haraken, 2016-06-02 11:16:10]

LGTM

[sof, 2016-06-02 11:55:56]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-06-02 11:56:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033643003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033643003/1

[sof, 2016-06-02 13:35:51]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2016-06-02 13:36:16]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-06-02 13:36:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033643003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033643003/1

[commit-bot: I haz the power, 2016-06-02 16:11:35]

Description was changed from

==========
Adjust representation of liveDocumentSet() to help diagnose instability.

The liveDocumentSet singleton keeps a

 Persistent<HeapHashSet<WeakMember<Document>>,

collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.

To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with an (Oilpan) heap object
overwrite here.

R=
BUG=611702
==========

to

==========
Adjust representation of liveDocumentSet() to help diagnose instability.

The liveDocumentSet singleton keeps a

 Persistent<HeapHashSet<WeakMember<Document>>,

collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.

To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with an (Oilpan) heap object
overwrite here.

R=
BUG=611702
==========

[commit-bot: I haz the power, 2016-06-02 16:11:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-02 16:12:48]

Description was changed from

==========
Adjust representation of liveDocumentSet() to help diagnose instability.

The liveDocumentSet singleton keeps a

 Persistent<HeapHashSet<WeakMember<Document>>,

collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.

To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with an (Oilpan) heap object
overwrite here.

R=
BUG=611702
==========

to

==========
Adjust representation of liveDocumentSet() to help diagnose instability.

The liveDocumentSet singleton keeps a

 Persistent<HeapHashSet<WeakMember<Document>>,

collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.

To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with an (Oilpan) heap object
overwrite here.

R=
BUG=611702

Committed: https://crrev.com/a606534af4c30e4c92e454d4bd54f09114d08374
Cr-Commit-Position: refs/heads/master@{#397436}
==========

[commit-bot: I haz the power, 2016-06-02 16:12:49]

Patchset 1 (id:??) landed as
https://crrev.com/a606534af4c30e4c92e454d4bd54f09114d08374
Cr-Commit-Position: refs/heads/master@{#397436}