Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2033643003: Adjust representation of liveDocumentSet() to help diagnose instability. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 return true; 359 return true;
360 if (errorMessage) 360 if (errorMessage)
361 *errorMessage = origin->isPotentiallyTrustworthyErrorMessage(); 361 *errorMessage = origin->isPotentiallyTrustworthyErrorMessage();
362 return false; 362 return false;
363 } 363 }
364 364
365 uint64_t Document::s_globalTreeVersion = 0; 365 uint64_t Document::s_globalTreeVersion = 0;
366 366
367 static bool s_threadedParsingEnabledForTesting = true; 367 static bool s_threadedParsingEnabledForTesting = true;
368 368
369 Document::WeakDocumentSet& Document::liveDocumentSet() 369 using WeakDocumentSet = PersistentHeapHashSet<WeakMember<Document>>;
370
371 static WeakDocumentSet& liveDocumentSet()
370 { 372 {
371 DEFINE_STATIC_LOCAL(WeakDocumentSet, set, (new WeakDocumentSet)); 373 DEFINE_STATIC_LOCAL(WeakDocumentSet, set, ());
372 return set; 374 return set;
373 } 375 }
374 376
375 // This class doesn't work with non-Document ExecutionContext. 377 // This class doesn't work with non-Document ExecutionContext.
376 class AutofocusTask final : public ExecutionContextTask { 378 class AutofocusTask final : public ExecutionContextTask {
377 public: 379 public:
378 static std::unique_ptr<AutofocusTask> create() 380 static std::unique_ptr<AutofocusTask> create()
379 { 381 {
380 return wrapUnique(new AutofocusTask()); 382 return wrapUnique(new AutofocusTask());
381 } 383 }
(...skipping 5646 matching lines...) Expand 10 before | Expand all | Expand 10 after
6028 } 6030 }
6029 6031
6030 template class CORE_TEMPLATE_EXPORT Supplement<Document>; 6032 template class CORE_TEMPLATE_EXPORT Supplement<Document>;
6031 6033
6032 } // namespace blink 6034 } // namespace blink
6033 6035
6034 #ifndef NDEBUG 6036 #ifndef NDEBUG
6035 using namespace blink; 6037 using namespace blink;
6036 void showLiveDocumentInstances() 6038 void showLiveDocumentInstances()
6037 { 6039 {
6038 Document::WeakDocumentSet& set = Document::liveDocumentSet(); 6040 WeakDocumentSet& set = liveDocumentSet();
6039 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6041 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6040 for (Document* document : set) 6042 for (Document* document : set)
6041 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data()); 6043 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data());
6042 } 6044 }
6043 #endif 6045 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698