chrome/browser/password_manager/password_manager_interactive_uitest.cc - Issue 2033643002: Disable PasswordManagerBrowserTestBase.UsernameChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_interactive_uitest.cc

Issue 2033643002: Disable PasswordManagerBrowserTestBase.UsernameChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/password_manager_interactive_uitest.cc

diff --git a/chrome/browser/password_manager/password_manager_interactive_uitest.cc b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

index 6a3fceea44e9d183ce295434cec56430e6c70578..748b230db826005ca2006726292b7feec37667f7 100644

--- a/chrome/browser/password_manager/password_manager_interactive_uitest.cc

+++ b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

@@ -36,7 +36,13 @@ void SimulateUserTypingInField(content::RenderViewHost* render_view_host,

namespace password_manager {

-IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, UsernameChanged) {

+// TODO(crbug.com/616627): Flaky on Mac, CrOS and Linux.

+#if defined(OS_MACOSX) || defined(OS_CHROMEOS) || defined(OS_LINUX)

+#define MAYBE_UsernameChanged DISABLED_UsernameChanged

+#else

+#define MAYBE_UsernameChanged UsernameChanged

+#endif

+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, MAYBE_UsernameChanged) {

scoped_refptr<password_manager::TestPasswordStore> password_store =

static_cast<password_manager::TestPasswordStore*>(

PasswordStoreFactory::GetForProfile(

« no previous file with comments | « no previous file | no next file » | no next file with comments »