Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/password_manager/password_manager_interactive_uitest.cc

Issue 2033643002: Disable PasswordManagerBrowserTestBase.UsernameChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/run_loop.h" 5 #include "base/run_loop.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/browser/password_manager/password_manager_test_base.h" 7 #include "chrome/browser/password_manager/password_manager_test_base.h"
8 #include "chrome/browser/password_manager/password_store_factory.h" 8 #include "chrome/browser/password_manager/password_store_factory.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "components/password_manager/core/browser/test_password_store.h" 10 #include "components/password_manager/core/browser/test_password_store.h"
(...skipping 18 matching lines...) Expand all
29 content::SimulateKeyPress(web_contents, ui::VKEY_R, false, false, false, 29 content::SimulateKeyPress(web_contents, ui::VKEY_R, false, false, false,
30 false); 30 false);
31 content::SimulateKeyPress(web_contents, ui::VKEY_Y, false, false, false, 31 content::SimulateKeyPress(web_contents, ui::VKEY_Y, false, false, false,
32 false); 32 false);
33 } 33 }
34 34
35 } // namespace 35 } // namespace
36 36
37 namespace password_manager { 37 namespace password_manager {
38 38
39 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, UsernameChanged) { 39 // TODO(crbug.com/616627): Flaky on Mac, CrOS and Linux.
40 #if defined(OS_MACOSX) || defined(OS_CHROMEOS) || defined(OS_LINUX)
41 #define MAYBE_UsernameChanged DISABLED_UsernameChanged
42 #else
43 #define MAYBE_UsernameChanged UsernameChanged
44 #endif
45 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, MAYBE_UsernameChanged) {
40 scoped_refptr<password_manager::TestPasswordStore> password_store = 46 scoped_refptr<password_manager::TestPasswordStore> password_store =
41 static_cast<password_manager::TestPasswordStore*>( 47 static_cast<password_manager::TestPasswordStore*>(
42 PasswordStoreFactory::GetForProfile( 48 PasswordStoreFactory::GetForProfile(
43 browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS).get()); 49 browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS).get());
44 50
45 NavigateToFile("/password/signup_form.html"); 51 NavigateToFile("/password/signup_form.html");
46 52
47 NavigationObserver observer(WebContents()); 53 NavigationObserver observer(WebContents());
48 std::unique_ptr<BubbleObserver> prompt_observer( 54 std::unique_ptr<BubbleObserver> prompt_observer(
49 new BubbleObserver(WebContents())); 55 new BubbleObserver(WebContents()));
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 password_store->stored_passwords(); 111 password_store->stored_passwords();
106 EXPECT_EQ(1u, stored_passwords.size()); 112 EXPECT_EQ(1u, stored_passwords.size());
107 EXPECT_EQ(2u, stored_passwords.begin()->second.size()); 113 EXPECT_EQ(2u, stored_passwords.begin()->second.size());
108 EXPECT_EQ(base::UTF8ToUTF16("temp"), 114 EXPECT_EQ(base::UTF8ToUTF16("temp"),
109 (stored_passwords.begin()->second)[0].username_value); 115 (stored_passwords.begin()->second)[0].username_value);
110 EXPECT_EQ(base::UTF8ToUTF16("tempORARY"), 116 EXPECT_EQ(base::UTF8ToUTF16("tempORARY"),
111 (stored_passwords.begin()->second)[1].username_value); 117 (stored_passwords.begin()->second)[1].username_value);
112 } 118 }
113 119
114 } // namespace password_manager 120 } // namespace password_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698