Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203363003: Remove do-nothing trace traits on primitive types (Closed)

Created:
6 years, 9 months ago by Erik Corry
Modified:
6 years, 9 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

Remove do-nothing trace traits on primitive types R=ager@chromium.org, wibling@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -52 lines) Patch
M Source/heap/Heap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/heap/HeapTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/heap/Visitor.h View 1 chunk +0 lines, -37 lines 0 comments Download
M Source/heap/Visitor.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Erik Corry
6 years, 9 months ago (2014-03-18 14:28:24 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 9 months ago (2014-03-18 14:29:53 UTC) #2
haraken
LGTM
6 years, 9 months ago (2014-03-18 14:30:02 UTC) #3
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-18 14:37:42 UTC) #4
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 9 months ago (2014-03-18 14:37:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/203363003/1
6 years, 9 months ago (2014-03-18 14:38:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 15:49:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-18 15:49:01 UTC) #8
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 9 months ago (2014-03-19 07:55:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/203363003/1
6 years, 9 months ago (2014-03-19 07:55:26 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 08:57:59 UTC) #11
Message was sent while issue was closed. 
Change committed as 169531

Powered by Google App Engine
This is Rietveld 408576698