Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: Source/heap/Heap.h

Issue 203363003: Remove do-nothing trace traits on primitive types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/heap/HeapTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1216 matching lines...) Expand 10 before | Expand all | Expand 10 after
1227 ASSERT_NOT_REACHED(); 1227 ASSERT_NOT_REACHED();
1228 } 1228 }
1229 1229
1230 static void markUsingGCInfo(Visitor* visitor, const void* buffer) 1230 static void markUsingGCInfo(Visitor* visitor, const void* buffer)
1231 { 1231 {
1232 visitor->mark(buffer, FinalizedHeapObjectHeader::fromPayload(buffer)->tr aceCallback()); 1232 visitor->mark(buffer, FinalizedHeapObjectHeader::fromPayload(buffer)->tr aceCallback());
1233 } 1233 }
1234 1234
1235 static void markNoTracing(Visitor* visitor, const void* t) 1235 static void markNoTracing(Visitor* visitor, const void* t)
1236 { 1236 {
1237 visitor->mark(t); 1237 visitor->mark(t, reinterpret_cast<TraceCallback>(0));
1238 } 1238 }
1239 1239
1240 template<typename T, typename Traits> 1240 template<typename T, typename Traits>
1241 static void trace(Visitor* visitor, T& t) 1241 static void trace(Visitor* visitor, T& t)
1242 { 1242 {
1243 CollectionBackingTraceTrait<WTF::ShouldBeTraced<Traits>::value, Traits:: isWeak, false, T, Traits>::mark(visitor, t); 1243 CollectionBackingTraceTrait<WTF::ShouldBeTraced<Traits>::value, Traits:: isWeak, false, T, Traits>::mark(visitor, t);
1244 } 1244 }
1245 1245
1246 template<typename T> 1246 template<typename T>
1247 static bool hasDeadMember(Visitor*, const T&) 1247 static bool hasDeadMember(Visitor*, const T&)
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
1714 // to export. This forces it to export all the methods from ThreadHeap. 1714 // to export. This forces it to export all the methods from ThreadHeap.
1715 template<> void ThreadHeap<FinalizedHeapObjectHeader>::addPageToHeap(const GCInf o*); 1715 template<> void ThreadHeap<FinalizedHeapObjectHeader>::addPageToHeap(const GCInf o*);
1716 template<> void ThreadHeap<HeapObjectHeader>::addPageToHeap(const GCInfo*); 1716 template<> void ThreadHeap<HeapObjectHeader>::addPageToHeap(const GCInfo*);
1717 extern template class HEAP_EXPORT ThreadHeap<FinalizedHeapObjectHeader>; 1717 extern template class HEAP_EXPORT ThreadHeap<FinalizedHeapObjectHeader>;
1718 extern template class HEAP_EXPORT ThreadHeap<HeapObjectHeader>; 1718 extern template class HEAP_EXPORT ThreadHeap<HeapObjectHeader>;
1719 #endif 1719 #endif
1720 1720
1721 } 1721 }
1722 1722
1723 #endif // Heap_h 1723 #endif // Heap_h
OLDNEW
« no previous file with comments | « no previous file | Source/heap/HeapTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698