Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2033563002: Remove obsolete StoragePartition check from old iframe signin path. (Closed)

Created:
4 years, 6 months ago by Charlie Reis
Modified:
4 years, 6 months ago
Reviewers:
caseq, Dan Beam
CC:
chromium-reviews, darin-cc_chromium.org, jam, anthonyvd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete StoragePartition check from old iframe signin path. For now, leave the UI thread hop in place for DevTools URLs, due to issue 616641. BUG=614808, 616282, 616641 TEST=Signin and Mac DevTools still work. Committed: https://crrev.com/f5a831f23ed6fdfed5507e5ce9766a7df5d4203c Cr-Commit-Position: refs/heads/master@{#397530}

Patch Set 1 : Try without thread hop #

Patch Set 2 : Add UI thread hop for DevTools #

Total comments: 3

Patch Set 3 : Add early return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -68 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 2 3 chunks +27 lines, -51 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Charlie Reis
dbeam@ and caseq@, can you review? This is the same as https://codereview.chromium.org/2007223003 except that it ...
4 years, 6 months ago (2016-06-02 16:42:11 UTC) #5
Charlie Reis
On 2016/06/02 16:42:11, Charlie Reis wrote: > There's a recently added linux_android_rel_ng test that was ...
4 years, 6 months ago (2016-06-02 17:30:24 UTC) #6
Dan Beam
https://codereview.chromium.org/2033563002/diff/40001/content/browser/webui/url_data_manager_backend.cc File content/browser/webui/url_data_manager_backend.cc (right): https://codereview.chromium.org/2033563002/diff/40001/content/browser/webui/url_data_manager_backend.cc#newcode278 content/browser/webui/url_data_manager_backend.cc:278: weak_factory_.GetWeakPtr())); did you meant to put a "return;" here?
4 years, 6 months ago (2016-06-02 18:58:07 UTC) #7
Charlie Reis
Thanks. Sadly, I couldn't find a Mac try bot that runs the DevToolsSanityTests (which would ...
4 years, 6 months ago (2016-06-02 19:01:42 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033563002/60001
4 years, 6 months ago (2016-06-02 19:03:00 UTC) #10
Dan Beam
if you realllly care, you could probably write a test that checks the current behavior ...
4 years, 6 months ago (2016-06-02 19:08:21 UTC) #11
Charlie Reis
On 2016/06/02 19:08:21, Dan Beam wrote: > if you realllly care, you could probably write ...
4 years, 6 months ago (2016-06-02 19:34:57 UTC) #12
caseq
lgtm
4 years, 6 months ago (2016-06-02 20:39:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033563002/60001
4 years, 6 months ago (2016-06-02 20:42:53 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-02 22:24:33 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 22:26:22 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f5a831f23ed6fdfed5507e5ce9766a7df5d4203c
Cr-Commit-Position: refs/heads/master@{#397530}

Powered by Google App Engine
This is Rietveld 408576698