Remove obsolete StoragePartition check from old iframe signin path.

Remove obsolete StoragePartition check from old iframe signin path.

BUG=614808
TEST=Signin still works.

Committed: https://crrev.com/1fa5e60dc33595d1bc56f0452370ee66feb544db
Cr-Commit-Position: refs/heads/master@{#396193}

[Charlie Reis, 2016-05-25 21:44:38]

creis@chromium.org changed reviewers:
+ anthonyvd@chromium.org, dbeam@chromium.org

[Charlie Reis, 2016-05-25 21:44:39]

dbeam@: Can you take a look, since I'm undoing part of your recent change here? 
(In fact, I'm wondering if we regressed a bit in your CL by not posting a task.)

anthonyvd@: Can you help verify that signin still works?  I've tested signing in
via chrome://chrome-signin, and the try jobs are passing.  Is there anything
else we should verify?

CC'ing clamy@, since this might make https://codereview.chromium.org/2002633002
unnecessary.

https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_d...
File content/browser/webui/url_data_manager_backend.cc (right):

https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_d...
content/browser/webui/url_data_manager_backend.cc:261: // callbacks happen as
they would for network requests.
I realize this modifies the optimization dbeam@ added in
https://codereview.chromium.org/1985983002, but it's how the code behaved prior
to inline signin (dating back to the initial commit [0]), and it sounds
intentional.  It's just a posted task and not a thread hop, and the name
StartAsync implies that it's expected.

[0]
https://chromium.googlesource.com/chromium/src/+blame/be7f2174ece293c452eb122...

[Dan Beam, 2016-05-25 21:48:19]

lgtm I suppose

https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_d...
File content/browser/webui/url_data_manager_backend.cc (right):

https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_d...
content/browser/webui/url_data_manager_backend.cc:265: const GURL url =
request_->url();
nit: just inline |url| now:

TRACE_EVENT_ASYNC_BEGIN1("browser", "DataManager:Request", this, "URL",
                         request_->url().possibly_invalid_spec());

[Charlie Reis, 2016-05-25 21:52:46]

https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_d...
File content/browser/webui/url_data_manager_backend.cc (right):

https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_d...
content/browser/webui/url_data_manager_backend.cc:265: const GURL url =
request_->url();
On 2016/05/25 21:48:19, Dan Beam wrote:
> nit: just inline |url| now:
> 
> TRACE_EVENT_ASYNC_BEGIN1("browser", "DataManager:Request", this, "URL",
>                          request_->url().possibly_invalid_spec());

Done.

[anthonyvd, 2016-05-26 16:07:16]

lgtm. As discussed, we switched to webviews over iframes for signin a while ago
so I don't expect this to have any impact.

Still, tested @gmail.com, @google.com with 2 factor, and SAML signin with this
patch just to make sure and didn't experience any issue.

[Charlie Reis, 2016-05-26 16:20:13]

On 2016/05/26 16:07:16, anthonyvd wrote:
> lgtm. As discussed, we switched to webviews over iframes for signin a while
ago
> so I don't expect this to have any impact.
> 
> Still, tested @gmail.com, @google.com with 2 factor, and SAML signin with this
> patch just to make sure and didn't experience any issue.

Thanks for verifying!  I'll proceed.

[Charlie Reis, 2016-05-26 16:20:21]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2016-05-26 16:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2007223003/#ps20001
(title: "Inline")

[commit-bot: I haz the power, 2016-05-26 16:21:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007223003/20001

[commit-bot: I haz the power, 2016-05-26 16:24:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 16:26:42]

Description was changed from

==========
Remove obsolete StoragePartition check from old iframe signin path.

BUG=614808
TEST=Signin still works.
==========

to

==========
Remove obsolete StoragePartition check from old iframe signin path.

BUG=614808
TEST=Signin still works.

Committed: https://crrev.com/1fa5e60dc33595d1bc56f0452370ee66feb544db
Cr-Commit-Position: refs/heads/master@{#396193}
==========

[commit-bot: I haz the power, 2016-05-26 16:26:43]

Patchset 2 (id:??) landed as
https://crrev.com/1fa5e60dc33595d1bc56f0452370ee66feb544db
Cr-Commit-Position: refs/heads/master@{#396193}

[caseq, 2016-05-31 23:20:03]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2022363002/ by caseq@chromium.org.

The reason for reverting is: This broke DevTools, please see bug for more
details.
BUG=616282.