Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2007223003: Remove obsolete StoragePartition check from old iframe signin path. (Closed)

Created:
4 years, 7 months ago by Charlie Reis
Modified:
4 years, 7 months ago
Reviewers:
anthonyvd, Dan Beam
CC:
chromium-reviews, clamy, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete StoragePartition check from old iframe signin path. BUG=614808 TEST=Signin still works. Committed: https://crrev.com/1fa5e60dc33595d1bc56f0452370ee66feb544db Cr-Commit-Position: refs/heads/master@{#396193}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Inline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -75 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 3 chunks +9 lines, -63 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Charlie Reis
dbeam@: Can you take a look, since I'm undoing part of your recent change here? ...
4 years, 7 months ago (2016-05-25 21:44:39 UTC) #2
Dan Beam
lgtm I suppose https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_data_manager_backend.cc File content/browser/webui/url_data_manager_backend.cc (right): https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_data_manager_backend.cc#newcode265 content/browser/webui/url_data_manager_backend.cc:265: const GURL url = request_->url(); nit: ...
4 years, 7 months ago (2016-05-25 21:48:19 UTC) #3
Charlie Reis
https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_data_manager_backend.cc File content/browser/webui/url_data_manager_backend.cc (right): https://codereview.chromium.org/2007223003/diff/1/content/browser/webui/url_data_manager_backend.cc#newcode265 content/browser/webui/url_data_manager_backend.cc:265: const GURL url = request_->url(); On 2016/05/25 21:48:19, Dan ...
4 years, 7 months ago (2016-05-25 21:52:46 UTC) #4
anthonyvd
lgtm. As discussed, we switched to webviews over iframes for signin a while ago so ...
4 years, 7 months ago (2016-05-26 16:07:16 UTC) #5
Charlie Reis
On 2016/05/26 16:07:16, anthonyvd wrote: > lgtm. As discussed, we switched to webviews over iframes ...
4 years, 7 months ago (2016-05-26 16:20:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007223003/20001
4 years, 7 months ago (2016-05-26 16:21:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 16:24:58 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1fa5e60dc33595d1bc56f0452370ee66feb544db Cr-Commit-Position: refs/heads/master@{#396193}
4 years, 7 months ago (2016-05-26 16:26:43 UTC) #12
caseq
4 years, 6 months ago (2016-05-31 23:20:03 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2022363002/ by caseq@chromium.org.

The reason for reverting is: This broke DevTools, please see bug for more
details.
BUG=616282.

Powered by Google App Engine
This is Rietveld 408576698