third_party/WebKit/Source/modules/webaudio/AudioParam.h - Issue 2033503004: Avoid slow AudioParam automation path when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParam.h

Issue 2033503004: Avoid slow AudioParam automation path when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js ('k') | third_party/WebKit/Source/modules/webaudio/AudioParam.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioParam.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParam.h b/third_party/WebKit/Source/modules/webaudio/AudioParam.h

index 42886883ba8d2176a8cc427963411447e8bb5b1b..ebdc00bd821e15d89080d12a2d4fe258da842f96 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioParam.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioParam.h

@@ -139,7 +139,7 @@ public:

// Returns true if smoothed value has already snapped exactly to value.

bool smooth();

- void resetSmoothedValue() { m_smoothedValue = intrinsicValue(); }

+ void resetSmoothedValue() { m_timeline.setSmoothedValue(intrinsicValue()); }

bool hasSampleAccurateValues() { return m_timeline.hasValues() || numberOfRenderingConnections(); }

@@ -181,9 +181,6 @@ private:

float m_minValue;

float m_maxValue;

- // Smoothing (de-zippering)

- float m_smoothedValue;

AudioParamTimeline m_timeline;

// The destination node used to get necessary information like the smaple rate and context time.