third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js - Issue 2033503004: Avoid slow AudioParam automation path when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js

Issue 2033503004: Avoid slow AudioParam automation path when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/osc-negative-freq.html ('k') | third_party/WebKit/Source/modules/webaudio/AudioParam.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js

diff --git a/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js b/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js

index 608d16a19e62260132a05dc4623e0649e968cc59..ebc337b26a69090d76881ea8dcab5b49c67dd971 100644

--- a/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js

+++ b/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js

@@ -870,9 +870,9 @@ var Should = (function () {

maxAbsError = diff;

}

// Keep track of the location of the max relative error, ignoring cases where the

- // relative error is ininfinity (because the expected value = 0).

+ // relative error is NaN.

var relError = diff / Math.abs(expected[i]);

- if (isFinite(relError) && relError > maxRelError) {

+ if (!isNaN(relError) && relError > maxRelError) {

maxRelErrorIndex = i;

maxRelError = relError;

}