Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1796)

Unified Diff: ui/views/controls/menu/menu_controller.h

Issue 2033433006: MacViews: Modify insertText handlers to correctly handle space key and simplify menu event dispatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/menu/menu_controller.h
diff --git a/ui/views/controls/menu/menu_controller.h b/ui/views/controls/menu/menu_controller.h
index 20c1bee5d2fc082c8e8e282c4e3f77f4f4d8bb2f..e0940352cce4fe46d2cc7bb4581d9a67c5d4b3fa 100644
--- a/ui/views/controls/menu/menu_controller.h
+++ b/ui/views/controls/menu/menu_controller.h
@@ -176,11 +176,10 @@ class VIEWS_EXPORT MenuController : public WidgetObserver {
void OnDragComplete(bool should_close);
// Called while dispatching messages to intercept key events.
- // If |character| is other than 0, it is handled as a mnemonic.
- // Otherwise, |key_code| is handled as a menu navigation command.
+ // If |event| is a character event, it is handled as a mnemonic.
+ // Otherwise, it is handled as a menu navigation command.
// Returns ui::POST_DISPATCH_NONE if the event was swallowed by the menu.
- ui::PostDispatchAction OnWillDispatchKeyEvent(base::char16 character,
- ui::KeyboardCode key_code);
+ ui::PostDispatchAction OnWillDispatchKeyEvent(const ui::KeyEvent& event);
// Update the submenu's selection based on the current mouse location
void UpdateSubmenuSelection(SubmenuView* source);

Powered by Google App Engine
This is Rietveld 408576698