MacViews: Modify insertText handlers to correctly handle space key and simplify menu event dispatch.

ui/views/controls/menu/menu_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_CONTROLLER_H_
 #define UI_VIEWS_CONTROLS_MENU_MENU_CONTROLLER_H_
 
 #include <stddef.h>
 
 #include <list>
@@ skipping 158 matching lines @@
   // Called by the Widget when a drag is about to start on a child view. This
   // could be initiated by one of our MenuItemViews, or could be through another
   // child View.
   void OnDragWillStart();
 
   // Called by the Widget when the drag has completed. |should_close|
   // corresponds to whether or not the menu should close.
   void OnDragComplete(bool should_close);
 
   // Called while dispatching messages to intercept key events.
-  // If |character| is other than 0, it is handled as a mnemonic.
-  // Otherwise, |key_code| is handled as a menu navigation command.
+  // If |event| is a character event, it is handled as a mnemonic.
+  // Otherwise, it is handled as a menu navigation command.
   // Returns ui::POST_DISPATCH_NONE if the event was swallowed by the menu.
-  ui::PostDispatchAction OnWillDispatchKeyEvent(base::char16 character,
-                                                ui::KeyboardCode key_code);
+  ui::PostDispatchAction OnWillDispatchKeyEvent(const ui::KeyEvent& event);
 
   // Update the submenu's selection based on the current mouse location
   void UpdateSubmenuSelection(SubmenuView* source);
 
   // WidgetObserver overrides:
   void OnWidgetDestroying(Widget* widget) override;
 
   // Only used for testing.
   bool IsCancelAllTimerRunningForTest();
 
@@ skipping 511 matching lines @@
 #if defined(USE_AURA)
   std::unique_ptr<MenuKeyEventHandler> key_event_handler_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(MenuController);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_MENU_MENU_CONTROLLER_H_