Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2033423002:
[builtins] Turn LoadIC_Miss and LoadIC_Slow builtins to TurboFan code stubs. (Closed)
|
Created:
4 years, 6 months ago by Igor Sheludko Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@load-ic-stub-tf Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[builtins] Turn LoadIC_Miss and LoadIC_Slow builtins to TurboFan code stubs.
Committed: https://crrev.com/2ef6862e5d89807fc1f12a1a86ba7ebf0b7112b2
Cr-Commit-Position: refs/heads/master@{#36915}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Different approach #Patch Set 3 : Comment added #Patch Set 4 : Rebasing #
Dependent Patchsets: Messages
Total messages: 26 (13 generated)
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033423002/1
ishell@chromium.org changed reviewers: + verwaest@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
nice cleanup! lgtm https://codereview.chromium.org/2033423002/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/2033423002/diff/1/src/code-stubs.h#newcode412 src/code-stubs.h:412: ExtraICState GetExtraICState() const override { return EXTRA_IC_STATE; } \ EXTRA_IC_STATE -> KIND? https://codereview.chromium.org/2033423002/diff/1/src/code-stubs.h#newcode976 src/code-stubs.h:976: DEFINE_TURBOFAN_HANDLER_CODE_STUB(LoadICMiss, Code::LOAD_IC); This is not a HANDLER but a STUB. We should probably just get rid of the distinction at this point since I think it doesn't matter anymore. (It used to, for harvesting feedback from code objects that would sometimes call e.g., this miss stub, and sometimes handlers. We had to have a way to distinguish handlers from the others.)
Description was changed from ========== [stubs] Introduce LoadICMiss and LoadICSlow TurboFan stubs instead of respective hand-written builtins. ========== to ========== [builtins] Turn LoadIC_Miss and LoadIC_Slow builtins to TurboFan code stubs. ==========
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033423002/40001
I've chosen completely different approach. PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033423002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bmeurer@chromium.org changed reviewers: + bmeurer@chromium.org
lgtm
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/2033423002/#ps80001 (title: "Rebasing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033423002/80001
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [builtins] Turn LoadIC_Miss and LoadIC_Slow builtins to TurboFan code stubs. ========== to ========== [builtins] Turn LoadIC_Miss and LoadIC_Slow builtins to TurboFan code stubs. Committed: https://crrev.com/2ef6862e5d89807fc1f12a1a86ba7ebf0b7112b2 Cr-Commit-Position: refs/heads/master@{#36915} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/2ef6862e5d89807fc1f12a1a86ba7ebf0b7112b2 Cr-Commit-Position: refs/heads/master@{#36915} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
