[ic] Split LoadIC into LoadGlobalIC and LoadIC.

[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
TBR=bmeurer@chromium.org

Committed: https://crrev.com/d9e8764f8132a6d5b84acfc54b27fde0cb65d963
Cr-Commit-Position: refs/heads/master@{#36965}

[Igor Sheludko, 2016-05-30 15:20:37]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

BUG=v8:4911
LOG=N
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

BUG=chromium:576312
LOG=N
==========

[Igor Sheludko, 2016-05-30 15:38:53]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

BUG=chromium:576312
LOG=N
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

The next step would be to remove receiver map tracking for LoadGlobalIC.

BUG=chromium:576312
LOG=N
==========

[Igor Sheludko, 2016-05-30 16:20:54]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

The next step would be to remove receiver map tracking for LoadGlobalIC.

BUG=chromium:576312
LOG=N
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

Currently LoadGlobalIC is still tracking receiver maps.

BUG=chromium:576312
LOG=N
==========

[Igor Sheludko, 2016-05-30 16:21:03]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-30 16:21:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912633002/40001

[commit-bot: I haz the power, 2016-05-30 16:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 16:25:01]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[Igor Sheludko, 2016-06-10 15:34:23]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-10 15:34:39]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

Currently LoadGlobalIC is still tracking receiver maps.

BUG=chromium:576312
LOG=N
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

BUG=chromium:576312
LOG=Y
==========

[Igor Sheludko, 2016-06-10 15:34:47]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-06-10 15:34:59]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-06-10 15:35:13]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-06-10 15:36:28]

Patchset #1 (id:80001) has been deleted

[Igor Sheludko, 2016-06-10 15:37:27]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle named
loads from explicit receiver.

BUG=chromium:576312
LOG=Y
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver.

BUG=chromium:576312
LOG=Y
==========

[Igor Sheludko, 2016-06-10 15:46:21]

Patchset #1 (id:100001) has been deleted

[Igor Sheludko, 2016-06-10 15:46:29]

Patchset #1 (id:120001) has been deleted

[Igor Sheludko, 2016-06-10 16:07:57]

Patchset #1 (id:140001) has been deleted

[Igor Sheludko, 2016-06-10 16:09:44]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver.

BUG=chromium:576312
LOG=Y
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
==========

[Igor Sheludko, 2016-06-10 16:13:59]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 16:14:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/160001

[commit-bot: I haz the power, 2016-06-10 16:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 16:15:37]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7118)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16970)

[Igor Sheludko, 2016-06-10 16:17:55]

Patchset #1 (id:160001) has been deleted

[Igor Sheludko, 2016-06-10 16:18:33]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 16:18:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/180001

[commit-bot: I haz the power, 2016-06-10 16:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 16:20:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3016)

[Igor Sheludko, 2016-06-10 18:13:43]

Patchset #1 (id:180001) has been deleted

[Igor Sheludko, 2016-06-10 18:14:31]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 18:14:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/200001

[commit-bot: I haz the power, 2016-06-10 18:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 18:19:32]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/7119)

[Igor Sheludko, 2016-06-10 18:38:41]

Patchset #1 (id:200001) has been deleted

[Igor Sheludko, 2016-06-10 18:38:51]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 18:38:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/220001

[commit-bot: I haz the power, 2016-06-10 19:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 19:09:32]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-10 19:41:12]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2016-06-10 19:41:13]

PTAL

[Igor Sheludko, 2016-06-13 07:47:36]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 07:47:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/240001

[commit-bot: I haz the power, 2016-06-13 07:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 07:49:15]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Igor Sheludko, 2016-06-13 07:57:33]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 07:57:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/260001

[commit-bot: I haz the power, 2016-06-13 08:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 08:26:06]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2016-06-13 14:06:41]

One comment, otherwise looks great!

https://codereview.chromium.org/1912633002/diff/220001/src/ast/ast.cc
File src/ast/ast.cc (right):

https://codereview.chromium.org/1912633002/diff/220001/src/ast/ast.cc#newcode133
src/ast/ast.cc:133: variable_feedback_slot_ = spec->AddLoadICSlot();
This is confusing, because it looks like it's saying "If I don't use a
VariableFeedbackSlot...then allocate a VariableFeedbackSlot."

Can the predicate UsesVariableFeedbackSlot() be redefined more usefully?

[mvstanton, 2016-06-13 14:15:28]

My bad, I thought the else was associated with the if above. LGTM.

[Igor Sheludko, 2016-06-14 12:27:21]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-14 12:27:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/260001

[commit-bot: I haz the power, 2016-06-14 12:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 12:30:58]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17184)

[Michael Starzinger, 2016-06-14 13:06:29]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-06-14 13:06:30]

LGTM on "ast", "compiler" and "interpreter". Didn't look at the rest.

[Igor Sheludko, 2016-06-14 13:07:39]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-14 13:07:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/260001

[commit-bot: I haz the power, 2016-06-14 13:13:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 13:13:40]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17190)

[Igor Sheludko, 2016-06-14 13:18:25]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
TBR=bmeurer@chromium.org
==========

[Igor Sheludko, 2016-06-14 13:18:35]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-14 13:18:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912633002/260001

[commit-bot: I haz the power, 2016-06-14 13:20:49]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
TBR=bmeurer@chromium.org
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
TBR=bmeurer@chromium.org
==========

[commit-bot: I haz the power, 2016-06-14 13:20:51]

Committed patchset #3 (id:260001)

[commit-bot: I haz the power, 2016-06-14 13:20:56]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 13:21:40]

Description was changed from

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
TBR=bmeurer@chromium.org
==========

to

==========
[ic] Split LoadIC into LoadGlobalIC and LoadIC.

The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
TBR=bmeurer@chromium.org

Committed: https://crrev.com/d9e8764f8132a6d5b84acfc54b27fde0cb65d963
Cr-Commit-Position: refs/heads/master@{#36965}
==========

[commit-bot: I haz the power, 2016-06-14 13:21:42]

Patchset 3 (id:??) landed as
https://crrev.com/d9e8764f8132a6d5b84acfc54b27fde0cb65d963
Cr-Commit-Position: refs/heads/master@{#36965}