third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js

index 18178b19ed80c1448509ca9001c765d8f00f5190..1f09c124c9b17abd9ca923c93794ddbdad6c7076 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js

@@ -119,12 +119,12 @@ WebInspector.StylesPopoverHelper.prototype = {

_onKeyDown: function(event)

{

- if (event.keyIdentifier === "Enter") {

+ if (event.key === "Enter") {

this.hide(true);

event.consume(true);

return;

}

- if (event.keyIdentifier === "U+001B") { // Escape key

+ if (event.key === "Escape") {

this.hide(false);

event.consume(true);

}