third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac build attempt 2 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_window.cc ('K') | « third_party/WebKit/LayoutTests/inspector/console/console-auto-completion.html ('k') | third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html » ('j') | third_party/WebKit/Source/devtools/front_end/devtools.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

diff --git a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

index d9f98d879ec8114565f6bd671708831853c6497d..53a18f8357fe8de19d85d43b2eb82b5529857096 100644

--- a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

+++ b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

@@ -316,14 +316,14 @@ function extension_testGlobalShortcuts(nextTest)

testPanel.onShown.removeListener(onPanelShown);

output("Panel shown, now toggling console...");

panelWindow.addEventListener("resize", onPanelResized);

- dispatchKeydownEvent({ keyIdentifier: "U+001B" });

+ dispatchKeydownEvent({ key: "Escape", keyIdentifier: "U+001B" });

}

function onPanelResized()

{

panelWindow.removeEventListener("resize", onPanelResized);

output("Panel resized, switching away...");

var isMac = platform === "mac";

- dispatchKeydownEvent({ ctrlKey: !isMac, metaKey: isMac, keyIdentifier: "U+005D" });

+ dispatchKeydownEvent({ ctrlKey: !isMac, metaKey: isMac, key: "]" });

}

function onPanelHidden()

{