Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mac build attempt 2 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/BUILD.gn ('k') | chrome/chrome_debugger.gypi » ('j') | third_party/WebKit/Source/devtools/front_end/devtools.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index e4143cc6de078864910844f79fa8e05e361d05d3..25f694d01233a78149d51a8d6fc06f2ba002ce86 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -51,6 +51,7 @@
#include "net/base/escape.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
#include "ui/base/page_transition_types.h"
+#include "ui/events/keycodes/dom/keycode_converter.h"
#include "ui/events/keycodes/keyboard_code_conversion.h"
#include "ui/events/keycodes/keyboard_codes.h"
@@ -273,6 +274,10 @@ bool DevToolsEventForwarder::ForwardEvent(
base::DictionaryValue event_data;
event_data.SetString("type", event_type);
event_data.SetString("keyIdentifier", event.keyIdentifier);
dgozman 2016/06/16 06:55:00 Do we have to pass this? I thought you are getting
dtapuska 2016/06/16 07:36:11 Right. I think this can now be removed.
+ event_data.SetString("key", ui::KeycodeConverter::DomKeyToKeyString(
+ static_cast<ui::DomKey>(event.domKey)));
+ event_data.SetString("code", ui::KeycodeConverter::DomCodeToCodeString(
+ static_cast<ui::DomCode>(event.domCode)));
event_data.SetInteger("keyCode", key_code);
event_data.SetInteger("modifiers", modifiers);
devtools_window_->bindings_->CallClientFunction(
« no previous file with comments | « chrome/browser/devtools/BUILD.gn ('k') | chrome/chrome_debugger.gypi » ('j') | third_party/WebKit/Source/devtools/front_end/devtools.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698