third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac build attempt 2 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_window.cc ('K') | « chrome/chrome_debugger.gypi ('k') | third_party/WebKit/LayoutTests/inspector/console/console-auto-completion.html » ('j') | third_party/WebKit/Source/devtools/front_end/devtools.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

index ec05a3ca5500978c1d2301bf4a222a464f34ac35..a48ff3434e7078c2312df665b4dba50fbcb3018c 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

@@ -23,8 +23,12 @@ InspectorTest.evaluateInConsole = function(code, callback, dontForceMainContext)

var consoleView = WebInspector.ConsoleView.instance();

consoleView.visible = true;

consoleView._prompt.setText(code);

- var event = document.createEvent("KeyboardEvent");

- event.initKeyboardEvent("keydown", true, true, null, "Enter", "");

+ var event = new KeyboardEvent("keydown", {

+ key: "Enter",

+ keyIdentifier: "Enter",

+ bubbles: true,

+ cancelable: true

+ });

consoleView._prompt.proxyElementForTests().dispatchEvent(event);

InspectorTest.addConsoleViewSniffer(function(commandResult) {

callback(commandResult.toMessageElement().deepTextContent());