Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2033403003: [iOS/GN] Add support for info_plist_target to ios_info_plist. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tweak_info_plist
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Add support for info_plist_target to ios_info_plist. Chrome on iOS needs to use tweak_info_plist, so port support for info_plist_target from mac_info_plist to ios_info_plist. BUG=617134 Committed: https://crrev.com/e0ab61670fb9d7826de41e313004a0e4d0379da6 Cr-Commit-Position: refs/heads/master@{#397727}

Patch Set 1 #

Patch Set 2 : Rebase on origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M build/config/ios/rules.gni View 8 chunks +40 lines, -10 lines 0 comments Download
M build/config/mac/rules.gni View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sdefresne
Please take a look.
4 years, 6 months ago (2016-06-03 12:51:36 UTC) #2
Robert Sesek
LGTM
4 years, 6 months ago (2016-06-03 14:06:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033403003/20001
4 years, 6 months ago (2016-06-03 14:58:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/81604)
4 years, 6 months ago (2016-06-03 16:00:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033403003/20001
4 years, 6 months ago (2016-06-03 16:10:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 16:38:53 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:41:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0ab61670fb9d7826de41e313004a0e4d0379da6
Cr-Commit-Position: refs/heads/master@{#397727}

Powered by Google App Engine
This is Rietveld 408576698