Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2033383002: Handle use of fromEnvironment from serialized data. (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle use of fromEnvironment from serialized data. This CL removes the [intEnvironment], [boolEnvironment] and [stringEnvironment] from [Compiler] and instead determine .fromEnvironment directly from the constructor element itself. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b11a92f2ed6511dde5a51fba090e5c6867cb27f9

Patch Set 1 #

Patch Set 2 : Fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -60 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 7 chunks +10 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +0 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 2 chunks +33 lines, -1 line 2 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 3 chunks +4 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +12 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 3 chunks +11 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 6 months ago (2016-06-03 10:04:21 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2033383002/diff/20001/pkg/compiler/lib/src/elements/common.dart File pkg/compiler/lib/src/elements/common.dart (right): https://codereview.chromium.org/2033383002/diff/20001/pkg/compiler/lib/src/elements/common.dart#newcode614 pkg/compiler/lib/src/elements/common.dart:614: return name == Identifiers.fromEnvironment && would it be ...
4 years, 6 months ago (2016-06-03 17:57:03 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as b11a92f2ed6511dde5a51fba090e5c6867cb27f9 (presubmit successful).
4 years, 6 months ago (2016-06-06 08:52:59 UTC) #5
Johnni Winther
4 years, 6 months ago (2016-06-13 07:49:20 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2033383002/diff/20001/pkg/compiler/lib/src/el...
File pkg/compiler/lib/src/elements/common.dart (right):

https://codereview.chromium.org/2033383002/diff/20001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/common.dart:614: return name ==
Identifiers.fromEnvironment &&
On 2016/06/03 17:57:03, Siggi Cherem (dart-lang) wrote:
> would it be worth caching the results of this?

Made a CL for it.

Powered by Google App Engine
This is Rietveld 408576698