Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 2033383002: Handle use of fromEnvironment from serialized data. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 8bfd231c4bf768199d3099ee7ad33ef20157ea9a..e1fd27102310ec9002e5d4ff473bbbf8dd42fda3 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -206,7 +206,9 @@ abstract class ElementX extends Element with ElementCommon {
}
}
-class ErroneousElementX extends ElementX implements ErroneousElement {
+class ErroneousElementX extends ElementX
+ with ConstructorElementCommon
+ implements ErroneousElement {
final MessageKind messageKind;
final Map messageArguments;
@@ -284,9 +286,6 @@ class ErroneousElementX extends ElementX implements ErroneousElement {
}
@override
- bool get isFromEnvironmentConstructor => false;
-
- @override
List<DartType> get typeVariables => unsupported();
}
@@ -2167,21 +2166,13 @@ abstract class ConstantConstructorMixin implements ConstructorElement {
}
}
- bool get isFromEnvironmentConstructor {
- return name == 'fromEnvironment' &&
- library.isDartCore &&
- (enclosingClass.name == 'bool' ||
- enclosingClass.name == 'int' ||
- enclosingClass.name == 'String');
- }
-
/// Returns the empty list of type variables by default.
@override
List<DartType> get typeVariables => functionSignature.typeVariables;
}
abstract class ConstructorElementX extends FunctionElementX
- with ConstantConstructorMixin
+ with ConstantConstructorMixin, ConstructorElementCommon
implements ConstructorElement {
bool isRedirectingGenerative = false;

Powered by Google App Engine
This is Rietveld 408576698