Issue 203333004: Handlification of JSArray::SetElementsLength().

Issue 203333004: Handlification of JSArray::SetElementsLength(). (Closed)

Created:
6 years, 9 months ago by Igor Sheludko

Modified:
6 years, 9 months ago

Reviewers:
Yang, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlification of JSArray::SetElementsLength(). R=verwaest@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20080

Patch Set 2 : Addressing review notes #

Total comments: 4

Patch Set 3 : Addressing review notes #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -48 lines)			Patch
M	src/accessors.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/elements.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/elements.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	1 2	2 chunks	+6 lines, -8 lines	0 comments	Download
M	src/objects.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1 2	2 chunks	+23 lines, -36 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit https://codereview.chromium.org/203333004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/203333004/diff/1/src/objects.cc#newcode11447 src/objects.cc:11447: if (!array->map()->is_observed()) Use { } if ...

6 years, 9 months ago (2014-03-19 13:38:47 UTC) #2

Yang

LGTM with nits. https://codereview.chromium.org/203333004/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/203333004/diff/20001/src/objects.cc#newcode11442 src/objects.cc:11442: // static I think you can ...

6 years, 9 months ago (2014-03-19 13:54:20 UTC) #3

Igor Sheludko

Committed patchset #3 manually as r20080 (presubmit successful).

6 years, 9 months ago (2014-03-19 14:09:59 UTC) #4

Igor Sheludko

6 years, 9 months ago (2014-03-19 14:14:23 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/203333004/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/203333004/diff/1/src/objects.cc#newcode11447
src/objects.cc:11447: if (!array->map()->is_observed())
On 2014/03/19 13:38:48, Toon Verwaest wrote:
> Use { } if multiline

Done.

https://codereview.chromium.org/203333004/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/203333004/diff/20001/src/objects.cc#newcode11442
src/objects.cc:11442: // static
On 2014/03/19 13:54:20, Yang wrote:
> I think you can remove that comment too.

Done.

https://codereview.chromium.org/203333004/diff/20001/src/objects.cc#newcode11455
src/objects.cc:11455: Handle<Object> new_length_handle = length;
On 2014/03/19 13:54:20, Yang wrote:
> Can we either rename the argument or rename the uses? So that we don't have
this
> duplicate. 

Done.

Expand Messages | Collapse Messages