src/elements.h - Issue 203333004: Handlification of JSArray::SetElementsLength().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.h

Issue 203333004: Handlification of JSArray::SetElementsLength(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review notes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.h

diff --git a/src/elements.h b/src/elements.h

index bfca9c1f8a6ebf16ba4d0070e4aa08e694be91d3..135e091a6ffe7ed69c97f6119c86a3d1a4235581 100644

--- a/src/elements.h

+++ b/src/elements.h

@@ -109,6 +109,9 @@ class ElementsAccessor {

// changing array sizes as defined in EcmaScript 5.1 15.4.5.2, i.e. array that

// have non-deletable elements can only be shrunk to the size of highest

// element that is non-deletable.

+ MUST_USE_RESULT virtual Handle<Object> SetLength(

+ Handle<JSArray> holder,

+ Handle<Object> new_length) = 0;

MUST_USE_RESULT virtual MaybeObject* SetLength(JSArray* holder,

Object* new_length) = 0;

« no previous file with comments | « src/accessors.cc ('k') | src/elements.cc » ('j') | no next file with comments »