Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2033283002: Implement bluetooth chooser for Chrome Apps on non-Mac desktops (Closed)

Created:
4 years, 6 months ago by juncai
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor_ChooserBubbleUiViewDelegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement bluetooth chooser for Chrome Apps on non-Mac desktops This is the part 5 of enabling the chooser UIs for Bluetooth from Apps to enable developers to make a transition. This CL implements the chooser UI for Bluetooth from Apps on non-Mac desktops. BUG=616602, 577170 Committed: https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc Cr-Commit-Position: refs/heads/master@{#399094}

Patch Set 1 : implemented bluetooth chooser for Chrome Apps on non-Mac desktops #

Total comments: 11

Patch Set 2 : address comments #

Patch Set 3 : added test code #

Patch Set 4 : updated test code #

Total comments: 21

Patch Set 5 : address comments #

Patch Set 6 : updated //components/OWNERS #

Patch Set 7 : rebase #

Patch Set 8 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -1 line) Patch
M chrome/browser/extensions/chrome_extension_chooser_dialog.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/ui/views/extensions/chooser_dialog_view.h View 1 2 3 4 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 1 2 3 4 1 chunk +145 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (7 generated)
juncai
reillyg@chromium.org: Please review changes in //chrome/browser/extensions/chrome_extension_chooser_dialog.h thakis@chromium.org: Please review changes in //chrome/chrome_browser_ui.gypi msw@chromium.org: Please review ...
4 years, 6 months ago (2016-06-03 01:32:37 UTC) #2
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2033283002/diff/1/chrome/browser/ui/views/extensions/chooser_dialog_view.h File chrome/browser/ui/views/extensions/chooser_dialog_view.h (right): https://codereview.chromium.org/2033283002/diff/1/chrome/browser/ui/views/extensions/chooser_dialog_view.h#newcode9 chrome/browser/ui/views/extensions/chooser_dialog_view.h:9: #include "chrome/browser/ui/views/chooser_content_view.h" This file appears to be missing from ...
4 years, 6 months ago (2016-06-03 19:27:07 UTC) #3
Reilly Grant (use Gerrit)
Never mind. lgtm
4 years, 6 months ago (2016-06-03 19:34:23 UTC) #4
msw
https://codereview.chromium.org/2033283002/diff/1/chrome/browser/extensions/chrome_extension_chooser_dialog.h File chrome/browser/extensions/chrome_extension_chooser_dialog.h (left): https://codereview.chromium.org/2033283002/diff/1/chrome/browser/extensions/chrome_extension_chooser_dialog.h#oldcode25 chrome/browser/extensions/chrome_extension_chooser_dialog.h:25: // TODO(juncai): remove this preprocessor directive once the non-Mac ...
4 years, 6 months ago (2016-06-03 19:46:24 UTC) #6
Evan Stade
https://codereview.chromium.org/2033283002/diff/1/chrome/browser/ui/views/extensions/chooser_dialog_view.h File chrome/browser/ui/views/extensions/chooser_dialog_view.h (right): https://codereview.chromium.org/2033283002/diff/1/chrome/browser/ui/views/extensions/chooser_dialog_view.h#newcode25 chrome/browser/ui/views/extensions/chooser_dialog_view.h:25: // views::BubbleDialogDelegateView: On 2016/06/03 19:46:24, msw wrote: > +estade ...
4 years, 6 months ago (2016-06-03 21:35:35 UTC) #7
Nico
test? chrome_browser_ui.gypi lgtm
4 years, 6 months ago (2016-06-04 00:59:02 UTC) #8
juncai
On 2016/06/04 00:59:02, Nico wrote: > test? > > chrome_browser_ui.gypi lgtm Added test code.
4 years, 6 months ago (2016-06-07 23:19:19 UTC) #9
juncai
https://codereview.chromium.org/2033283002/diff/1/chrome/browser/extensions/chrome_extension_chooser_dialog.h File chrome/browser/extensions/chrome_extension_chooser_dialog.h (left): https://codereview.chromium.org/2033283002/diff/1/chrome/browser/extensions/chrome_extension_chooser_dialog.h#oldcode25 chrome/browser/extensions/chrome_extension_chooser_dialog.h:25: // TODO(juncai): remove this preprocessor directive once the non-Mac ...
4 years, 6 months ago (2016-06-07 23:19:39 UTC) #10
msw
https://codereview.chromium.org/2033283002/diff/60001/chrome/browser/ui/views/extensions/chooser_dialog_view.cc File chrome/browser/ui/views/extensions/chooser_dialog_view.cc (right): https://codereview.chromium.org/2033283002/diff/60001/chrome/browser/ui/views/extensions/chooser_dialog_view.cc#newcode27 chrome/browser/ui/views/extensions/chooser_dialog_view.cc:27: const int kChooserDialogWidth = 300; nit: these are shared ...
4 years, 6 months ago (2016-06-08 01:16:32 UTC) #11
juncai
https://codereview.chromium.org/2033283002/diff/60001/chrome/browser/ui/views/extensions/chooser_dialog_view.cc File chrome/browser/ui/views/extensions/chooser_dialog_view.cc (right): https://codereview.chromium.org/2033283002/diff/60001/chrome/browser/ui/views/extensions/chooser_dialog_view.cc#newcode27 chrome/browser/ui/views/extensions/chooser_dialog_view.cc:27: const int kChooserDialogWidth = 300; On 2016/06/08 01:16:32, msw ...
4 years, 6 months ago (2016-06-09 01:59:53 UTC) #12
msw
lgtm https://codereview.chromium.org/2033283002/diff/60001/chrome/browser/ui/views/extensions/chooser_dialog_view.cc File chrome/browser/ui/views/extensions/chooser_dialog_view.cc (right): https://codereview.chromium.org/2033283002/diff/60001/chrome/browser/ui/views/extensions/chooser_dialog_view.cc#newcode147 chrome/browser/ui/views/extensions/chooser_dialog_view.cc:147: void ChromeExtensionChooserDialog::ShowDialogImpl( On 2016/06/09 01:59:53, juncai wrote: > ...
4 years, 6 months ago (2016-06-09 18:40:05 UTC) #13
commit-bot: I haz the power
This CL has an open dependency (Issue 2029863002 Patch 300001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-10 04:13:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033283002/140001
4 years, 6 months ago (2016-06-10 04:28:09 UTC) #19
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 6 months ago (2016-06-10 04:35:08 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 04:35:22 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 04:37:36 UTC) #23
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc
Cr-Commit-Position: refs/heads/master@{#399094}

Powered by Google App Engine
This is Rietveld 408576698