Implement bluetooth chooser for Chrome Apps on non-Mac desktops

chrome/browser/ui/views/extensions/chooser_dialog_view.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_CHOOSER_DIALOG_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_CHOOSER_DIALOG_VIEW_H_
+
+#include "base/macros.h"
+#include "chrome/browser/ui/views/chooser_content_view.h"

[Reilly Grant (use Gerrit), 2016/06/03 19:27:07]

This file appears to be missing from your patch.

[msw, 2016/06/03 19:46:24]

This CL depends on https://codereview.chromium.org/2029863002

+
+class ChooserController;
+
+namespace content {
+class WebContents;
+}
+
+// Displays a chooser dialog as a modal sheet constrained

[msw, 2016/06/03 19:46:24]

nit: "sheet" is a Mac term, right? Consider: "Displays a chooser view as a modal
dialog constrained"...

[juncai, 2016/06/07 23:19:39]

Done.

+// to the window/tab displaying the given web contents.
+class ChooserDialogView : public ChooserContentView {
+ public:
+  ChooserDialogView(content::WebContents* web_contents,
+                    ChooserController* controller);
+  ~ChooserDialogView() override;
+
+  // views::BubbleDialogDelegateView:

[msw, 2016/06/03 19:46:24]

+estade for sanity checking the use of BubbleDialogDelegateView with
ShowWebModalDialogViews / DialogDelegate::CreateDialogWidgetWithBounds... Should
this just work as-is or should it override
CreateNonClientFrameView/ShouldUseCustomFrame/etc?

[Evan Stade, 2016/06/03 21:35:35]

yea I think this is going to give some weird behavior around padding and stuff.
It's somewhat unintended and worrisome that this even works at all. I think you
need to use composition instead, i.e. own a ChooserContentView which is just a
View, and make that a contained view of ChooserDialogView. It can also provide
GetDialogButtonLabel, IsDialogButtonEnabled, and CreateFootnoteView, and your
ChooserDialogView will have to call these as pass throughs. (Same story for
ChooserBubbleUiViewDelegate.)

[juncai, 2016/06/07 23:19:39]

Done.

+  base::string16 GetWindowTitle() const override;
+  ui::ModalType GetModalType() const override;
+  void DeleteDelegate() override;
+  bool Accept() override;
+  bool Cancel() override;
+  bool Close() override;
+
+ private:
+  content::WebContents* web_contents_;
+  DISALLOW_COPY_AND_ASSIGN(ChooserDialogView);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_CHOOSER_DIALOG_VIEW_H_