Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2195)

Unified Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.h

Issue 2033183002: [SPv2] Paint invalidation in PreWalkTreeWalk, plumbed on PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RootFrame
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/PaintInvalidationState.h
diff --git a/third_party/WebKit/Source/core/layout/PaintInvalidationState.h b/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
index 8ab40a46aab57411b83bfe3a0890be6d378f4e86..014b68ef9f7465203da33d25418d15b6e91e7ac3 100644
--- a/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
+++ b/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
@@ -35,7 +35,7 @@ enum VisualRectFlags {
// needs of the paint invalidation systems (keeping visual rectangles
// instead of layout specific information).
//
-// See Source/core/paint/README.md ### PaintInvalidationState for more details.
+// See Source/core/paint/README.md#Paint-invalidation for more details.
class CORE_EXPORT PaintInvalidationState {
DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
@@ -46,7 +46,7 @@ public:
// For root LayoutView, or when sub-frame LayoutView's invalidateTreeIfNeeded() is called directly from
// FrameView::invalidateTreeIfNeededRecursive() instead of the owner LayoutPart.
// TODO(wangxianzhu): Eliminate the latter case.
- PaintInvalidationState(const LayoutView&, Vector<LayoutObject*>& pendingDelayedPaintInvalidations);
+ PaintInvalidationState(const LayoutView&, Vector<const LayoutObject*>& pendingDelayedPaintInvalidations);
// When a PaintInvalidationState is constructed, it can be used to map points/rects in the object's
// local space (border box space for LayoutBoxes). After invalidation of the current object,
@@ -76,10 +76,6 @@ public:
void mapLocalRectToPaintInvalidationBacking(LayoutRect&) const;
- // Records |obj| as needing paint invalidation on the next frame. See the definition of PaintInvalidationDelayedFull for more details.
- void pushDelayedPaintInvalidationTarget(LayoutObject& obj) const { m_pendingDelayedPaintInvalidations.append(&obj); }
- Vector<LayoutObject*>& pendingDelayedPaintInvalidationTargets() const { return m_pendingDelayedPaintInvalidations; }
-
PaintLayer& paintingLayer() const;
#if ENABLE(ASSERT)
@@ -145,7 +141,8 @@ private:
// with |m_paintOffset| yields the "final" offset.
AffineTransform m_svgTransform;
- Vector<LayoutObject*>& m_pendingDelayedPaintInvalidations;
+ // Records objects needing paint invalidation on the next frame. See the definition of PaintInvalidationDelayedFull for more details.
+ Vector<const LayoutObject*>& m_pendingDelayedPaintInvalidations;
PaintLayer& m_paintingLayer;

Powered by Google App Engine
This is Rietveld 408576698