third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp - Issue 2033183002: [SPv2] Paint invalidation in PreWalkTreeWalk, plumbed on PaintInvalidationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

Issue 2033183002: [SPv2] Paint invalidation in PreWalkTreeWalk, plumbed on PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RootFrame

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.h ('k') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

diff --git a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

index 07b5e361fbee14735bda680b5369120d56f2f039..c3076c44fdd9bf6bca105712098a6ecad085288e 100644

--- a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

+++ b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

@@ -27,7 +27,7 @@ static bool supportsCachedOffsets(const LayoutObject& object)

&& !(object.isLayoutBlock() && object.isSVG());

}

-PaintInvalidationState::PaintInvalidationState(const LayoutView& layoutView, Vector<LayoutObject*>& pendingDelayedPaintInvalidations)

+PaintInvalidationState::PaintInvalidationState(const LayoutView& layoutView, Vector<const LayoutObject*>& pendingDelayedPaintInvalidations)

: m_currentObject(layoutView)

, m_forcedSubtreeInvalidationFlags(0)

, m_clipped(false)

@@ -71,7 +71,7 @@ PaintInvalidationState::PaintInvalidationState(const PaintInvalidationState& par

, m_paintInvalidationContainerForStackedContents(parentState.m_paintInvalidationContainerForStackedContents)

, m_containerForAbsolutePosition(currentObject.canContainAbsolutePositionObjects() ? currentObject : parentState.m_containerForAbsolutePosition)

, m_svgTransform(parentState.m_svgTransform)

- , m_pendingDelayedPaintInvalidations(parentState.pendingDelayedPaintInvalidationTargets())

+ , m_pendingDelayedPaintInvalidations(parentState.m_pendingDelayedPaintInvalidations)

, m_paintingLayer(currentObject.hasLayer() && toLayoutBoxModelObject(currentObject).hasSelfPaintingLayer() ? *toLayoutBoxModelObject(currentObject).layer() : parentState.m_paintingLayer)

#if ENABLE(ASSERT)

, m_didUpdateForChildren(false)

@@ -244,7 +244,7 @@ void PaintInvalidationState::updateForChildren(PaintInvalidationReason reason)

switch (reason) {

case PaintInvalidationDelayedFull:

- pushDelayedPaintInvalidationTarget(const_cast<LayoutObject&>(m_currentObject));

+ m_pendingDelayedPaintInvalidations.append(&m_currentObject);

break;

case PaintInvalidationSubtree:

m_forcedSubtreeInvalidationFlags |= (FullInvalidation | FullInvalidationForStackedContents);