Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3888)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 2033173002: Moving Breakpad Windows specific logic to lower layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 886690a41657723eeab758aef5ce48a04f54d58d..9c0e997b0283be30cdd1ea73eacef700a17f565d 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -1658,23 +1658,6 @@ void BrowserOptionsHandler::HandleDefaultZoomFactor(
}
void BrowserOptionsHandler::HandleRestartBrowser(const base::ListValue* args) {
-#if defined(OS_WIN)
- // On Windows Breakpad will upload crash reports if the breakpad pipe name
- // environment variable is defined. So we undefine this environment variable
- // before restarting, as the restarted processes will inherit their
- // environment variables from ours, thus suppressing crash uploads.
- if (!ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled()) {
- HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
- if (exe_module) {
- typedef void (__cdecl *ClearBreakpadPipeEnvVar)();
- ClearBreakpadPipeEnvVar clear = reinterpret_cast<ClearBreakpadPipeEnvVar>(
- GetProcAddress(exe_module, "ClearBreakpadPipeEnvironmentVariable"));
- if (clear)
- clear();
- }
- }
-#endif
-
chrome::AttemptRestart();
}
« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc ('k') | chrome/browser/ui/webui/settings/system_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698