chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc - Issue 2033173002: Moving Breakpad Windows specific logic to lower layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

Issue 2033173002: Moving Breakpad Windows specific logic to lower layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comment. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_accessor.h ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

diff --git a/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc b/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

index b00380b3a337f61d13ce648eb1afd8b5a1be9ef2..a3b39b426afbae652b1afd7127bf6f8d9047d6b3 100644

--- a/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

+++ b/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

@@ -22,6 +22,10 @@

#include "components/prefs/pref_registry_simple.h"

#include "components/prefs/testing_pref_service.h"

+#if defined(OS_WIN)

+#include "components/metrics/metrics_pref_names.h"

+#endif

typedef BrowserWithTestWindowTest BrowserListTest;

namespace {

@@ -171,8 +175,11 @@ TEST_F(BrowserListTest, MAYBE_AttemptRestart) {

testing_pref_service.registry()->RegisterBooleanPref(

prefs::kWasRestarted, false);

testing_pref_service.registry()->RegisterBooleanPref(

- prefs::kRestartLastSessionOnShutdown,

- false);

+ prefs::kRestartLastSessionOnShutdown, false);

+#if defined(OS_WIN)

+ testing_pref_service.registry()->RegisterBooleanPref(

+ metrics::prefs::kMetricsReportingEnabled, false);

+#endif

testing_pref_service.registry()->RegisterListPref(

prefs::kProfilesLastActive);