Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2033133004: X87: Temporary workaround for X87 FPU convert SNaN to QNaN automatically issue. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Temporary workaround for X87 FPU convert SNaN to QNaN automatically issue. x87 FPU converts the SNaN to QNaN automatically when loading SNaN from memmory. This function caused v8 x87 port can't distinguish the Hole NaN (V8 used SNaN for it) from Javascript visible NaNs (V8 used QNaN for it). Many test cases failed in this function for v8 x87 port. It's a big effort to refactor all code of x87 FPU loads value from memmory to fix this issue. So here's a temporary workaround for it, what's this CL does are: 1. Removed all previous x87 workaround of this issue. 2. Used SNaN of MIPS which is a not used QNaN in v8 x87 port as the Hole NaN for v8 x87 port. 3. This CL is only local to x87 port. BUG= Committed: https://crrev.com/22a73e0d854638ca26d8a49434a605f1fde0daf8 Cr-Commit-Position: refs/heads/master@{#36697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M src/globals.h View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zhengxing.li
Hi, Benedikt: we talked about this issue in E-Mail already, please help to review this ...
4 years, 6 months ago (2016-06-03 07:50:00 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-03 07:50:34 UTC) #3
zhengxing.li
On 2016/06/03 07:50:34, Benedikt Meurer wrote: > lgtm thanks!
4 years, 6 months ago (2016-06-03 07:51:30 UTC) #4
Weiliang
lgtm
4 years, 6 months ago (2016-06-03 07:54:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033133004/1
4 years, 6 months ago (2016-06-03 08:00:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 08:31:56 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:33:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22a73e0d854638ca26d8a49434a605f1fde0daf8
Cr-Commit-Position: refs/heads/master@{#36697}

Powered by Google App Engine
This is Rietveld 408576698