X87: Temporary workaround for X87 FPU convert SNaN to QNaN automatically issue.

src/crankshaft/x87/lithium-codegen-x87.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_X87
 
 #include "src/crankshaft/x87/lithium-codegen-x87.h"
 
 #include "src/base/bits.h"
 #include "src/code-factory.h"
@@ skipping 2344 matching lines @@
   __ fstp(0);
   EmitFalseBranch(instr, no_condition);
   __ bind(&ok);
 
 
   __ sub(esp, Immediate(kDoubleSize));
   __ fstp_d(MemOperand(esp, 0));
 
   __ add(esp, Immediate(kDoubleSize));
   int offset = sizeof(kHoleNanUpper32);
-  // x87 converts sNaN(0xfff7fffffff7ffff) to QNaN(0xfffffffffff7ffff),
-  // so we check the upper with 0xffffffff for hole as a temporary fix.
-  __ cmp(MemOperand(esp, -offset), Immediate(0xffffffff));
+  __ cmp(MemOperand(esp, -offset), Immediate(kHoleNanUpper32));
   EmitBranch(instr, equal);
 }
 
 
 Condition LCodeGen::EmitIsString(Register input,
                                  Register temp1,
                                  Label* is_not_string,
                                  SmiCheck check_needed = INLINE_SMI_CHECK) {
   if (check_needed == INLINE_SMI_CHECK) {
     __ JumpIfSmi(input, is_not_string);
@@ skipping 1720 matching lines @@
         instr->hydrogen()->key()->representation(), elements_kind,
         instr->base_offset() + kPointerSize);
 
     Label no_special_nan_handling, done;
     X87Register value = ToX87Register(instr->value());
     X87Fxch(value);
     __ lea(esp, Operand(esp, -kDoubleSize));
     __ fst_d(MemOperand(esp, 0));
     __ lea(esp, Operand(esp, kDoubleSize));
     int offset = sizeof(kHoleNanUpper32);
-    // x87 converts sNaN(0xfff7fffffff7ffff) to QNaN(0xfffffffffff7ffff),
-    // so we check the upper with 0xffffffff for hole as a temporary fix.
-    __ cmp(MemOperand(esp, -offset), Immediate(0xffffffff));
+    __ cmp(MemOperand(esp, -offset), Immediate(kHoleNanUpper32));
     __ j(not_equal, &no_special_nan_handling, Label::kNear);
     __ mov(operand, Immediate(lower));
     __ mov(operand2, Immediate(upper));
     __ jmp(&done, Label::kNear);
 
     __ bind(&no_special_nan_handling);
     __ fst_d(operand);
     __ bind(&done);
   } else {
     Register value = ToRegister(instr->value());
@@ skipping 65 matching lines @@
       __ j(parity_odd, &no_special_nan_handling, Label::kNear);
       // All NaNs are Canonicalized to 0x7fffffffffffffff
       __ mov(double_store_operand, Immediate(0xffffffff));
       __ mov(double_store_operand2, Immediate(0x7fffffff));
       __ jmp(&done, Label::kNear);
     } else {
       __ lea(esp, Operand(esp, -kDoubleSize));
       __ fst_d(MemOperand(esp, 0));
       __ lea(esp, Operand(esp, kDoubleSize));
       int offset = sizeof(kHoleNanUpper32);
-      // x87 converts sNaN(0xfff7fffffff7ffff) to QNaN(0xfffffffffff7ffff),
-      // so we check the upper with 0xffffffff for hole as a temporary fix.
-      __ cmp(MemOperand(esp, -offset), Immediate(0xffffffff));
+      __ cmp(MemOperand(esp, -offset), Immediate(kHoleNanUpper32));
       __ j(not_equal, &no_special_nan_handling, Label::kNear);
       __ mov(double_store_operand, Immediate(lower));
       __ mov(double_store_operand2, Immediate(upper));
       __ jmp(&done, Label::kNear);
     }
     __ bind(&no_special_nan_handling);
     __ fst_d(double_store_operand);
     __ bind(&done);
   }
 }
@@ skipping 1663 matching lines @@
   __ bind(deferred->exit());
   __ bind(&done);
 }
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_X87