Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: tools/clang/value_cleanup/tests/list-append-string-original.cc

Issue 2032983002: base::Value cleanup: add simple Clang tool for structured cleanups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/value_cleanup/tests/list-append-string-original.cc
diff --git a/tools/clang/value_cleanup/tests/list-append-string-original.cc b/tools/clang/value_cleanup/tests/list-append-string-original.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4000330bb0b13f29e181cb367384ddece01abdb1
--- /dev/null
+++ b/tools/clang/value_cleanup/tests/list-append-string-original.cc
@@ -0,0 +1,10 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/values.h"
dcheng 2016/06/02 08:04:49 I didn't feel like duping the base::Value API here
danakj 2016/06/02 18:33:02 I am unaware of reasons why this could be bad. *th
dcheng 2016/06/02 19:51:33 Yeah I just don't want some weird instance where t
+
+void F() {
+ base::ListValue list;
+ list.Append(new base::StringValue("abc"));
+}

Powered by Google App Engine
This is Rietveld 408576698