Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: tools/clang/value_cleanup/tests/list-append-string-original.cc

Issue 2032983002: base::Value cleanup: add simple Clang tool for structured cleanups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/values.h"
dcheng 2016/06/02 08:04:49 I didn't feel like duping the base::Value API here
danakj 2016/06/02 18:33:02 I am unaware of reasons why this could be bad. *th
dcheng 2016/06/02 19:51:33 Yeah I just don't want some weird instance where t
6
7 void F() {
8 base::ListValue list;
9 list.Append(new base::StringValue("abc"));
10 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698