Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 203293005: Fix crash in 2D canvas drawSystemFocusRing with invalid argument. (Closed)

Created:
6 years, 9 months ago by Justin Novosad
Modified:
6 years, 9 months ago
Reviewers:
Stephen White
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, dmazzoni
Visibility:
Public.

Description

Fix crash in 2D canvas drawSystemFocusRing with invalid argument. Added missing null ptr check. BUG=353248 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M LayoutTests/fast/canvas/draw-system-focus-ring.html View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/draw-system-focus-ring-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Justin Novosad
PTAL
6 years, 9 months ago (2014-03-18 18:40:28 UTC) #1
Stephen White
LGTM
6 years, 9 months ago (2014-03-18 19:03:08 UTC) #2
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 9 months ago (2014-03-18 19:05:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/203293005/1
6 years, 9 months ago (2014-03-18 19:11:42 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 20:14:46 UTC) #5
Message was sent while issue was closed.
Change committed as 169468

Powered by Google App Engine
This is Rietveld 408576698