Source/core/html/canvas/CanvasRenderingContext2D.cpp - Issue 203293005: Fix crash in 2D canvas drawSystemFocusRing with invalid argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/CanvasRenderingContext2D.cpp

Issue 203293005: Fix crash in 2D canvas drawSystemFocusRing with invalid argument. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/canvas/CanvasRenderingContext2D.cpp

diff --git a/Source/core/html/canvas/CanvasRenderingContext2D.cpp b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

index ef14b3f8911c4d39d749f93a67782f4f382cc767..307b2946078a608683ca101d0ac664b34f4e9458 100644

--- a/Source/core/html/canvas/CanvasRenderingContext2D.cpp

+++ b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

@@ -2238,7 +2238,7 @@ bool CanvasRenderingContext2D::focusRingCallIsValid(const Path& path, Element* e

return false;

if (path.isEmpty())

return false;

- if (!element->isDescendantOf(canvas()))

+ if (!element || !element->isDescendantOf(canvas()))

return false;

return true;

« no previous file with comments | « LayoutTests/fast/canvas/draw-system-focus-ring-expected.txt ('k') | no next file » | no next file with comments »