Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2032903003: Switch how we track whether trackDdcProfile is set to reduce the performance impact. sra was seeing… (Closed)

Created:
4 years, 6 months ago by Jacob
Modified:
4 years, 6 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch how we track whether trackDdcProfile is set to reduce the performance impact. sra was seeing this call hit 14% usage in the chrome profile. Fill in whitelist call ist and add support for list of whitelists that apply to calls only. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c0a7866b58aa558c02e6b05298b723e3f293b6ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +7 lines, -1 line 0 comments Download
M lib/src/compiler/code_generator.dart View 3 chunks +22 lines, -4 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
sra made the good point that checking a property that is undefined is very expensive. ...
4 years, 6 months ago (2016-06-02 23:17:19 UTC) #2
vsm
lgtm
4 years, 6 months ago (2016-06-02 23:58:02 UTC) #3
Jacob
4 years, 6 months ago (2016-06-02 23:59:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0a7866b58aa558c02e6b05298b723e3f293b6ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698