Switch how we track whether trackDdcProfile is set to reduce the performance impact. sra was seeing…

lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 import 'dart:math' show min, max;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart' show Token, TokenType;
@@ skipping 2691 matching lines @@
   /// an expression.
   JS.Expression _emitFunctionCall(InvocationExpression node) {
     var fn = _visit(node.function);
     var args = _visit(node.argumentList) as List<JS.Expression>;
     if (DynamicInvoke.get(node.function)) {
       var typeArgs = _emitInvokeTypeArguments(node);
       if (typeArgs != null) {
         return js.call('dart.dgcall(#, #, #)',
             [fn, new JS.ArrayInitializer(typeArgs), args]);
       } else {
-        if (_inWhitelistCode(node)) {
+        if (_inWhitelistCode(node, isCall: true)) {
           return new JS.Call(fn, args);
         }
         return js.call('dart.dcall(#, #)', [fn, args]);
       }
     } else {
       return new JS.Call(_applyInvokeTypeArguments(fn, node), args);
     }
   }
 
   JS.Expression _applyInvokeTypeArguments(
@@ skipping 1909 matching lines @@
       // TODO(leafp): The above only handles the case where the return type
       // is exactly Future/Stream/Iterable.  Handle the subtype case.
       return DynamicTypeImpl.instance;
     }
   }
 
   /// Maps whitelisted files to a list of whitelisted methods
   /// within the file.
   ///
   /// If the value is null, the entire file is whitelisted.
-  static Map<String, List<String>> _uncheckedWhitelist = {};
+  static Map<String, List<String>> _uncheckedWhitelist = {
+    'dom_renderer.dart': ['moveNodesAfterSibling',],
+    'template_ref.dart': ['createEmbeddedView'],
+    'ng_class.dart': ['_applyIterableChanges'],
+    'ng_for.dart': ['_bulkRemove', '_bulkInsert'],
+    'view_container_ref.dart': ['createEmbeddedView'],
+    'default_iterable_differ.dart': null,
+  };
 
-  bool _inWhitelistCode(AstNode node) {
+  static Set<String> _uncheckedWhitelistCalls = new Set()
+    ..add('ng_zone_impl.dart')
+    ..add('stack_zone_specification.dart')
+    ..add('view_manager.dart')
+    ..add('view.dart');
+
+  bool _inWhitelistCode(AstNode node, {isCall: false}) {
     if (!options.useAngular2Whitelist) return false;
     var path = _loader.currentElement.source.fullName;
     var filename = path.split("/").last;
     if (_uncheckedWhitelist.containsKey(filename)) {
       var whitelisted = _uncheckedWhitelist[filename];
       if (whitelisted == null) return true;
       var enclosing = node;
       while (enclosing != null &&
           !(enclosing is ClassMember || enclosing is FunctionDeclaration)) {
         enclosing = enclosing.parent;
       }
       String name = (enclosing as dynamic)?.element?.name;
       if (name != null) {
         return whitelisted.contains(name);
       }
     }
+
+    // Dynamic calls are less risky so there is no need to whitelist at the
+    // method level.
+    if (isCall && _uncheckedWhitelistCalls.contains(filename)) return true;
+
     return path.endsWith(".template.dart");
   }
 }
 
 /// Choose a canonical name from the library element.
 /// This never uses the library's name (the identifier in the `library`
 /// declaration) as it doesn't have any meaningful rules enforced.
 String jsLibraryName(String buildRoot, LibraryElement library) {
   var uri = library.source.uri;
   if (uri.scheme == 'dart') {
@@ skipping 41 matching lines @@
 }
 
 bool isLibraryPrefix(Expression node) =>
     node is SimpleIdentifier && node.staticElement is PrefixElement;
 
 LibraryElement _getLibrary(AnalysisContext c, String uri) =>
     c.computeLibraryElement(c.sourceFactory.forUri(uri));
 
 bool _isDartRuntime(LibraryElement l) =>
     l.isInSdk && l.source.uri.toString() == 'dart:_runtime';