Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2032743003: Not show the launcher during Chrome app installation (Closed)

Created:
4 years, 6 months ago by yoshiki
Modified:
4 years, 6 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Not show the launcher during Chrome app installation We are currently showing notifications during Chrome app installation from CWS, so we don't need to show the launcher. BUG=606843 TEST=manual test Committed: https://crrev.com/dc15c85fddf3fdad7624a4b0b9b5db557343e65d Cr-Commit-Position: refs/heads/master@{#397963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
yoshiki
benwells@. PTAL. Thanks.
4 years, 6 months ago (2016-06-03 07:05:03 UTC) #4
benwells
lgtm
4 years, 6 months ago (2016-06-06 01:11:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032743003/20001
4 years, 6 months ago (2016-06-06 02:17:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-06 03:17:03 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 03:19:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc15c85fddf3fdad7624a4b0b9b5db557343e65d
Cr-Commit-Position: refs/heads/master@{#397963}

Powered by Google App Engine
This is Rietveld 408576698