Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 2032743003: Not show the launcher during Chrome app installation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index d5d8fb8c5754ed95e8f93f7fdd2b6ca7b648844a..6e66b28ddd30cb90fc0a458627f66833c223af22 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -324,7 +324,6 @@ void WebstorePrivateBeginInstallWithManifest3Function::HandleInstallProceed() {
chrome_details_.GetProfile(), details().id,
std::move(parsed_manifest_), false));
approval->use_app_installed_bubble = !!details().app_install_bubble;
- approval->enable_launcher = !!details().enable_launcher;
// If we are enabling the launcher, we should not show the app list in order
// to train the user to open it themselves at least once.
approval->skip_post_install_ui = !!details().enable_launcher;
@@ -411,22 +410,6 @@ WebstorePrivateCompleteInstallFunction::Run() {
scoped_active_install_.reset(new ScopedActiveInstall(
InstallTracker::Get(browser_context()), params->expected_id));
- AppListService* app_list_service = AppListService::Get();
-
- if (approval_->enable_launcher) {
- app_list_service->EnableAppList(chrome_details_.GetProfile(),
- AppListService::ENABLE_FOR_APP_INSTALL);
- }
-
- if (IsAppLauncherEnabled() && approval_->manifest->is_app()) {
- // Show the app list to show download is progressing. Don't show the app
- // list on first app install so users can be trained to open it themselves.
- app_list_service->ShowForAppInstall(
- chrome_details_.GetProfile(),
- params->expected_id,
- approval_->enable_launcher);
- }
-
// Balanced in OnExtensionInstallSuccess() or OnExtensionInstallFailure().
AddRef();
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698