Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/bidirectional_stream_impl.h

Issue 2032733002: Do not crash on null stream in writing to bidirectional streams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_crash
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/bidirectional_stream.h ('K') | « net/http/bidirectional_stream.h ('k') | net/quic/bidirectional_stream_quic_impl.cc » ('j') | net/quic/bidirectional_stream_quic_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream_impl.h
diff --git a/net/http/bidirectional_stream_impl.h b/net/http/bidirectional_stream_impl.h
index 2dd9e8d14b8a7c799ba434d8777c6c1ab24f5cf0..c5a9f13325029a9b7a6c78205debe2c5a0a1f7ea 100644
--- a/net/http/bidirectional_stream_impl.h
+++ b/net/http/bidirectional_stream_impl.h
@@ -74,8 +74,8 @@ class NET_EXPORT_PRIVATE BidirectionalStreamImpl {
// EOF has not been received, or to send data if there is no pending send.
virtual void OnTrailersReceived(const SpdyHeaderBlock& trailers) = 0;
- // Called when an error occurred.
- // No other delegate functions will be called after this.
+ // Called when an error occurred. Do not cal into the stream after this
mef 2016/06/01 21:53:15 cal -> call.
xunjieli 2016/06/01 23:08:22 Done.
+ // point.
virtual void OnFailed(int status) = 0;
protected:
« net/http/bidirectional_stream.h ('K') | « net/http/bidirectional_stream.h ('k') | net/quic/bidirectional_stream_quic_impl.cc » ('j') | net/quic/bidirectional_stream_quic_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698