net/http/bidirectional_stream.h - Issue 2032733002: Do not crash on null stream in writing to bidirectional streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/bidirectional_stream.h

Issue 2032733002: Do not crash on null stream in writing to bidirectional streams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_crash

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/bidirectional_stream.h

diff --git a/net/http/bidirectional_stream.h b/net/http/bidirectional_stream.h

index cc54b0d97478a0d393ba5ddcb36222a47efaf136..db655fb9f59490d1057545bced6730278ea214cd 100644

--- a/net/http/bidirectional_stream.h

+++ b/net/http/bidirectional_stream.h

@@ -81,8 +81,8 @@ class NET_EXPORT BidirectionalStream

// EOF has not been received, or to send data if there is no pending send.

virtual void OnTrailersReceived(const SpdyHeaderBlock& trailers) = 0;

- // Called when the stream is closed or an error occurred.

- // No other delegate functions will be called after this.

+ // Called when an error occurred. Do not call into the stream after this

+ // point.

kapishnikov 2016/06/01 22:09:49 I think it is important to keep the contract that

xunjieli 2016/06/01 23:08:22 Done.

virtual void OnFailed(int error) = 0;

protected:

« no previous file with comments | « no previous file | net/http/bidirectional_stream_impl.h » ('j') | net/http/bidirectional_stream_impl.h » ('J')