Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2032643003: CC Animation: Erase EaseTimingFunction helpers. (Closed)

Created:
4 years, 6 months ago by loyso (OOO)
Modified:
4 years, 6 months ago
Reviewers:
ajuma
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, cc-bugs_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@gmock
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Erase EaseTimingFunction helpers. Ease*TimingFunction are static-only helpers, unrelated to base class TimingFunction. BUG=577016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/1e4e7ee016f5e0ab8ff4e1902358c327bd234997 Cr-Commit-Position: refs/heads/master@{#397609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -126 lines) Patch
M cc/animation/element_animations_unittest.cc View 9 chunks +27 lines, -18 lines 0 comments Download
M cc/animation/keyframed_animation_curve_unittest.cc View 7 chunks +36 lines, -26 lines 0 comments Download
M cc/animation/scroll_offset_animation_curve.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/animation/scroll_offset_animation_curve_unittest.cc View 5 chunks +14 lines, -8 lines 0 comments Download
M cc/animation/scroll_offset_animations_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/animation/timing_function.h View 1 chunk +0 lines, -32 lines 0 comments Download
M cc/animation/timing_function.cc View 2 chunks +9 lines, -28 lines 0 comments Download
M cc/input/top_controls_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/animation_test_common.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorFloatAnimationCurveTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
loyso (OOO)
4 years, 6 months ago (2016-06-02 05:37:30 UTC) #4
ajuma
lgtm
4 years, 6 months ago (2016-06-02 14:10:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032643003/1
4 years, 6 months ago (2016-06-03 00:21:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/75884) android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, ...
4 years, 6 months ago (2016-06-03 00:29:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032643003/1
4 years, 6 months ago (2016-06-03 00:55:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 03:05:04 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 03:06:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e4e7ee016f5e0ab8ff4e1902358c327bd234997
Cr-Commit-Position: refs/heads/master@{#397609}

Powered by Google App Engine
This is Rietveld 408576698