cc/animation/scroll_offset_animation_curve.cc - Issue 2032643003: CC Animation: Erase EaseTimingFunction helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/scroll_offset_animation_curve.cc

Issue 2032643003: CC Animation: Erase EaseTimingFunction helpers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/animation/scroll_offset_animation_curve.cc

diff --git a/cc/animation/scroll_offset_animation_curve.cc b/cc/animation/scroll_offset_animation_curve.cc

index 5b95f561685fa48533c61b4a1efebb5c894ae3e0..b207994c092a327a70c753d99b7c93f4446bf4c2 100644

--- a/cc/animation/scroll_offset_animation_curve.cc

+++ b/cc/animation/scroll_offset_animation_curve.cc

@@ -69,7 +69,8 @@ static std::unique_ptr<TimingFunction> EaseOutWithInitialVelocity(

// Clamp velocity to a sane value.

velocity = std::min(std::max(velocity, -1000.0), 1000.0);

- // Based on EaseInOutTimingFunction::Create with first control point scaled.

+ // Based on CubicBezierTimingFunction::EaseType::EASE_IN_OUT preset

+ // with first control point scaled.

const double x1 = 0.42;

const double y1 = velocity * x1;

return CubicBezierTimingFunction::Create(x1, y1, 0.58, 1);