core/fxge/win32/fx_win32_dwrite.cpp - Issue 2032613003: Get rid of NULLs in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/win32/fx_win32_dwrite.cpp

Issue 2032613003: Get rid of NULLs in core/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Git rid of comparisons against NULL Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/win32/fx_win32_dwrite.cpp

diff --git a/core/fxge/win32/fx_win32_dwrite.cpp b/core/fxge/win32/fx_win32_dwrite.cpp

index aa6ba9c8b978a10de93c3fc760097ac0b5cbf72e..18d528cae5c4cc4d0bf556c16b47889461f170c5 100644

--- a/core/fxge/win32/fx_win32_dwrite.cpp

+++ b/core/fxge/win32/fx_win32_dwrite.cpp

@@ -46,7 +46,7 @@ class CDwFontFileStream final : public IDWriteFontFileStream {

virtual void STDMETHODCALLTYPE ReleaseFileFragment(void* fragmentContext);

virtual HRESULT STDMETHODCALLTYPE GetFileSize(OUT UINT64* fileSize);

virtual HRESULT STDMETHODCALLTYPE GetLastWriteTime(OUT UINT64* lastWriteTime);

- bool IsInitialized() { return resourcePtr_ != NULL; }

+ bool IsInitialized() { return !!resourcePtr_; }

private:

ULONG refCount_;

@@ -70,7 +70,7 @@ class CDwFontFileLoader final : public IDWriteFontFileLoader {

}

return instance_;

}

- static bool IsLoaderInitialized() { return instance_ != NULL; }

+ static bool IsLoaderInitialized() { return !!instance_; }

private:

CDwFontFileLoader();